Deallocate IP address according to warm IP target when multiple enis are present #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikashmishra100
force-pushed
the
multiple_eni_deallocation
branch
from
28bac5e
to
7f89405
Compare
jdn5126
reviewed
May 3, 2023
There was a problem hiding this comment.
Thanks for the contribution @bikashmishra100 ! Just a few nits from me
jdn5126
approved these changes
May 12, 2023
|
@bikashmishra100 sorry for the delay. I approved these changes, but it looks like this branch requires merge conflict resolution. Can you rebase and resolve conflicts? Also @jayanthvn can you review as well? |
bikashmishra100
force-pushed
the
multiple_eni_deallocation
branch
from
f3c02ca
to
8482e0d
Compare
|
No problem at all @jdn5126 . I have squashed all the commits and rebased it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#2363
What does this PR do / Why do we need it:
Previously when multiple enis were present on the host, the deallocation loop used to exit when first eni did not have any available IP addresses to free. This PR fixes that. Also the PR deallocates exactly the required addresses below the target in case of multiple enis.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.