Introduce DISABLE_LEAKED_ENI_CLEANUP to disable leaked ENI cleanup task
#2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
force-pushed
the
warm_target_0
branch
4 times, most recently
from
236eaa2
to
5680c38
Compare
jayanthvn
reviewed
May 9, 2023
jayanthvn
reviewed
May 9, 2023
jdn5126
force-pushed
the
warm_target_0
branch
2 times, most recently
from
4383feb
to
b3e9f4b
Compare
jayanthvn
reviewed
May 10, 2023
| return getEnvBoolWithDefault(envDisableENIProvisioning, false) | ||
| } | ||
|
|
||
| func disableLeakedENICleanup() bool { |
There was a problem hiding this comment.
Can we rename this? I am not getting a good variable name but something like disableENIOperations
There was a problem hiding this comment.
This is used exclusively for disabling the leaked ENI cleanup task, though. It doesn't disable other ENI operations. disableENIProvisioning is the flag we use for cases like not allocating or deallocating an ENI
There was a problem hiding this comment.
Right, but the API is checking if v6 is enabled or disable ENI provisioning is set or disabled leaked eni cleanup is set..so it would be better to have some common name for readability.
There was a problem hiding this comment.
Will sync up offline on this..
jayanthvn
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
#2360
What does this PR do / Why do we need it:
This PR adds a new environment variable,
DISABLE_LEAKED_ENI_CLEANUP, that disables the leaked ENI cleanup task that IPAMD runs every hour. It also disables the task for IPv6 clusters. The task runs on each node every hour and creates a burst of EC2 API calls that can lead to throttling in larger accounts. Eventually, the task of cleaning up leaked ENIs will move to the VPC Resource Controller. This solution is to help customers in the interim.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually verified that task does not run when environment variable is set and that existing integration tests pass.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.