cni-metrics-helper add podAnnotation value #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @prysmakou! Let's follow the example set by the Also, can you update the title and description to be cni instead of csi? |
prysmakou
force-pushed
the
feat/helm_chart_pod_annotations
branch
from
bbe3a9c
to
7d89202
Compare
prysmakou
changed the title
jdn5126
reviewed
Jan 11, 2024
prysmakou
force-pushed
the
feat/helm_chart_pod_annotations
branch
from
cd858ba
to
ead633f
Compare
prysmakou
changed the title
jdn5126
approved these changes
Jan 17, 2024
jdn5126
force-pushed
the
feat/helm_chart_pod_annotations
branch
from
3f9956b
to
dc91820
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
cni-metrics-helper add deployment.podAnnotation value
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
Allows to add arbitrary annotations to pods (eg DataDog requires specific annotation to scrap Prometheus metrics)
Testing done on this change:
manual deploy
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
It changes the deployment/daemonset
Does this PR introduce any user-facing change?:
It introduces a new parameter in cni-metrics-helper helm chart (with a default value {} )
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.