Pod MTU #2791
Merged
Pod MTU #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen6585
commented
Feb 8, 2024
| @@ -267,6 +267,14 @@ Default: empty | |||
| Specify a comma-separated list of IPv4 CIDRs to exclude from SNAT. For every item in the list an `iptables` rule and off\-VPC | |||
| IP rule will be applied. If an item is not a valid ipv4 range it will be skipped. This should be used when `AWS_VPC_K8S_CNI_EXTERNALSNAT=false`. | |||
|
|
|||
| #### `POD_MTU` (v1.x.x+) | |||
There was a problem hiding this comment.
Placeholder version
jdn5126
reviewed
Feb 12, 2024
jdn5126
approved these changes
Feb 13, 2024
| *Note*: The default value is set to AWS_VPC_ENI_MTU, which defaults to 9001 if unset. | ||
| Default: 9001 | ||
|
|
||
| Used to configure the MTU size for pod virtual interfaces. The valid range is from `576` to `9001`. |
There was a problem hiding this comment.
576 is only valid for IPv4, otherwise the minimum MTU has to be 1280 (IPv6)
There was a problem hiding this comment.
Good call @archoversight. @jchen6585 we should update the README for AWS_VPC_ENI_MTU and POD_MTU at the very least, and we can consider adding runtime logging to error if IPv6 is configured and the MTU is < 1280
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
#2606
What does this PR do / Why do we need it:
Implements a new env var
POD_MTUthat sets the pod MTU. This will default toAWS_VPC_ENI_MTUvalue if not set.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Ran CNI, IPAMD, and IPv6 test suites.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.