Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpc-shared-eni: Enable IP forwarding and ARP proxy when using L3 mode #24

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Conversation

ofiliz
Copy link
Contributor

@ofiliz ofiliz commented Aug 2, 2019

Issue #, if available:

Description of changes:
vpc-shared-eni's L3 mode requires IP forwarding and ARP proxy to be enabled on Linux. We were previously configuring these outside the CNI plugin. To make the plugin more robust, without relying on any external configuration, the plugin now enables forwarding and ARP proxy on its interfaces.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ofiliz
Copy link
Contributor Author

ofiliz commented Aug 2, 2019

@abpath @vsiddharth Please take a look and build the CNI plugin with these changes when testing in EKS.

Copy link

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ofiliz, this looks good.

@ofiliz ofiliz merged commit cdd89b9 into aws:master Aug 3, 2019
@ofiliz ofiliz deleted the ipcfg branch August 3, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants