vpc-shared-eni: Remove call to get Pod from API Server in DEL command #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to query the API Server on DEL command as we get the Endpoint details using the container ID. We only query the API Server on ADD comand to get the IP Address from the Pod's Annotation. Note: IP Address information will be required for EKS Linux node which are not supported yet. Resolves: aws#42
abhipth
requested review from
ofiliz and
vsiddharth
and removed request for
ofiliz
ofiliz
reviewed
Aug 5, 2020
| // The only additional information we need to query from API server is the pod IP address, | ||
| // which is required only for ADD commands. Also the API server may have deleted the pod | ||
| // object already in the DEL path. | ||
| if !isAddCmd || args == nil || args.Args == "" { |
There was a problem hiding this comment.
We could have this block at line 75 (right after populating the kc fields), so that the namespace, podname and podinfracontainerid are available also in the DEL path. I understand they are not currently used, so this is more for completeness rather than functional correctness. Not a big deal.
There was a problem hiding this comment.
Makes sense, fixed it in the next commit.
ofiliz
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @ofiliz, refactoring the code in a cleaner way with additional comments explaining the reason for the change.
Description of changes:
We don't need to query the API Server on DEL command as we get the
Endpoint details using the container ID. We only query the API Server
on ADD command to get the IP Address from the Pod's Annotation.
Note: IP Address information will be required for EKS Linux node which
are not supported yet.
Resolves: #42
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.