Mutator and Validator Webhooks for GatewayRoute #192
Conversation
|
|
||
| // +kubebuilder:rbac:groups="",resources=namespaces,verbs=get;list;watch | ||
|
|
||
| func (d *membershipDesignator) DesignateNamespace(ctx context.Context, obj metav1.Object) (*appmesh.VirtualGateway, error) { |
There was a problem hiding this comment.
We also need to check whether the VirtualGateway and the the given Namespace belongs to the same mesh.
| // DesignatePod will choose a VirtualGateway for given pod. | ||
| DesignatePod(ctx context.Context, pod *corev1.Pod) (*appmesh.VirtualGateway, error) | ||
| // DesignateNamespace will choose a VirtualGateway for given namespaced GatewayRoute CR. | ||
| DesignateNamespace(ctx context.Context, obj metav1.Object) (*appmesh.VirtualGateway, error) |
There was a problem hiding this comment.
i'd favor like below to be more specific.
DesignateForGatewayRoute(ctx context.Context, obj *appmesh.GatewayRoute)
DesignateForPod(ctx context.Context, pod *corev1.Pod) (*appmesh.VirtualGateway, error)
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if virtualGateway.Spec.MeshRef.UID != mesh.UID { |
There was a problem hiding this comment.
we can use
(virtualGateway.Spec.MeshRef == nil || !mesh.isMeshReferenced(mesh, *virtualGateway.Spec.MeshRef) to check for both name & UID.
we should check for virtualGateway.Spec.MeshRef == nil, even it will only be nil when webhooks is disabled. (but the consequences is the controller will crash if it's nil)
however need to either rename the "mesh" variable to something like "ms", or rename the mesh package when import.
Issue #, if available:
aws-app-mesh-roadmap #37
Description of changes:
This PR is separated to two commits:
Testing
make docker-build && make docker-pushmake deployBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.