Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for ingress gateway using App Mesh in k8s #299

Merged
merged 7 commits into from Jun 12, 2020
Merged

Add example for ingress gateway using App Mesh in k8s #299

merged 7 commits into from Jun 12, 2020

Conversation

fawadkhaliq
Copy link

Description of changes:

  • Added an example for using Ingress in k8s using VirtualGateway feature in App Mesh
  • Also, fixed two README typos in other examples

The envoy configuration has APPMESH_PREVIEW enabled. We will disable it once the controller moves away from preview

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fawadkhaliq fawadkhaliq changed the title Add example for ingress gateway using App Mesh in k8s [WIP] Add example for ingress gateway using App Mesh in k8s Jun 9, 2020
@fawadkhaliq fawadkhaliq marked this pull request as draft June 9, 2020 16:35
@jlbutler
Copy link
Collaborator

jlbutler commented Jun 9, 2020

You can remove feapp from this demo, right? In deploy.sh and the feapp directory.

@fawadkhaliq fawadkhaliq changed the title [WIP] Add example for ingress gateway using App Mesh in k8s Add example for ingress gateway using App Mesh in k8s Jun 10, 2020
@fawadkhaliq
Copy link
Author

You can remove feapp from this demo, right? In deploy.sh and the feapp directory.

Thanks. Removed

Copy link
Contributor

@bcelenza bcelenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few more comments for the updated guide. Nice to see gateway working in k8s!

@fawadkhaliq fawadkhaliq marked this pull request as ready for review June 12, 2020 22:30
@fawadkhaliq fawadkhaliq merged commit ccdb3c1 into aws:master Jun 12, 2020
@fawadkhaliq fawadkhaliq deleted the ingress-k8s branch June 12, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants