Fix EKS Prometheus PVC pending problem #543
Conversation
walkthroughs/eks/o11y-prometheus.md
Outdated
| @@ -56,6 +81,34 @@ Similarly, you can see all the scraped metrics (including application health met | |||
|
|
|||
| ## Cleanup | |||
|
|
|||
| helm3 would support --purge by default | |||
There was a problem hiding this comment.
Does this line need to be here?
There was a problem hiding this comment.
Because the eks-charts repo gives outdated error hints, so give a special note here
walkthroughs/eks/o11y-prometheus.md
Outdated
| ``` | ||
| If the node doesn't have enough resources, you can scale |
There was a problem hiding this comment.
Can the be extended a bit? Maybe If the node doesn't have enough resources, you can try scaling the cluster.
walkthroughs/eks/o11y-prometheus.md
Outdated
| @@ -8,7 +8,32 @@ Prometheus is a systems and service monitoring system. It collects metrics from | |||
|
|
|||
| ### Option 1: Quick setup | |||
|
|
|||
| App Mesh provides a basic installation to setup Prometheus quickly using Helm. To install the Prometheus pre-configured to work with App Mesh, follow the instructions in [appmesh-prometheus](https://github.com/aws/eks-charts/blob/master/stable/appmesh-prometheus/README.md) Helm charts. | |||
| App Mesh provides a basic installation to setup Prometheus quickly using Helm. To install the Prometheus pre-configured to work with App Mesh: | |||
| 1. Enable EBS CSI Driver: | |||
There was a problem hiding this comment.
Are these instructions needed ot use the appmesh-prometheus chart? If so it seems like we should add them there rather than pulling them into this repo.
There was a problem hiding this comment.
Yes these are appmesh-prometheus changes. I originally thought we didn't have eks charts change access, let me move these over
walkthroughs/eks/o11y-prometheus.md
Outdated
| helm delete appmesh-prometheus -n appmesh-system | ||
| helm delete appmesh-prometheus --namespace appmesh-system | ||
| ``` | ||
| helm3 would support --purge by default. Do not follow the *Uninstalling the Chart* step in [appmesh-prometheus](https://github.com/aws/eks-charts/blob/master/stable/appmesh-prometheus/README.md) |
There was a problem hiding this comment.
Is this because the instructions are incorrect in the appmesh-prometheus chart? If so lets fix them instead of calling them out as incorrect here.
Fix EKS Prometheus PVC pending problem
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.