Replace APPMESH_VIRTUAL_NODE_NAME with APPMESH_RESOURCE_ARN #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroshni
approved these changes
Apr 19, 2023
| @@ -183,7 +183,7 @@ Resources: | |||
| awslogs-region: !Ref AWS::Region | |||
| awslogs-stream-prefix: "database-envoy" | |||
| Environment: | |||
| - Name: "APPMESH_VIRTUAL_NODE_NAME" | |||
| - Name: "APPMESH_RESOURCE_ARN" | |||
There was a problem hiding this comment.
So this new env variable doesn't actually need the full arn?
There was a problem hiding this comment.
Yes, that's true.
awsjdgls
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Replace deprecated environment variable APPMESH_VIRTUAL_NODE_NAME with APPMESH_RESOURCE_ARN by following the AppMesh official documentation.
Maintain the value of the field to be only mesh name and resource name to keep it consistent with other use cases from this git repo.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.