Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For serviceexport, targets are built for all ports of instead of just port specified in the serviceimport of backendRefs #267

Closed
liwenwu-amazon opened this issue Jun 13, 2023 · 2 comments
Closed

For serviceexport, targets are built for all ports of instead of just port specified in the serviceimport of backendRefs #267

liwenwu-amazon opened this issue Jun 13, 2023 · 2 comments

Comments

@liwenwu-amazon
Copy link
Contributor

This is similar to #241 . The same issue happens for serviceexport too.
@liwenwu-amazon
Copy link
Contributor Author

workaround: create a separate K8S service which only contains the ports need to used and create a separate service export object to reference this K8S service

@jansvive
Copy link

Thanks for the feature request! We will be adding this to our intake for prioritization, but we also try to take in popular feature requests based on 👍:skin-tone-4: from the community.

@liwenwu-amazon liwenwu-amazon mentioned this issue Jun 28, 2023
Merged
liwenwu-amazon pushed a commit that referenced this issue Jun 28, 2023
@sesmaili
#267 Added support for Port Annotation in ServiceExport Object (#280)
b830489 
* Added Port Annotations to ServiceExport

* optimized the code

* examples and test

* Moved the port annotations key to a const

* Removed extra logs

* Added integration tests

* Addressed the comments on the PR

---------

Co-authored-by: Salman Esmaili <>
@solmonk solmonk closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@solmonk @liwenwu-amazon @jansvive