add e2e cleanup script #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijun726911
reviewed
Sep 5, 2023
scripts/cleanup.sh
Outdated
| kubectl get serviceimports -n $n -l 'testing.kubernetes.io in (true)' | grep -v NAME | awk '{print $1}' | xargs kubectl delete serviceimport -n $n | ||
| kubectl get httproutes -n $n -l 'testing.kubernetes.io in (true)' | grep -v NAME | awk '{print $1}' | xargs kubectl delete httproute -n $n | ||
| kubectl get gateway -n $n -l 'testing.kubernetes.io in (true)' | grep -v NAME | awk '{print $1}' | xargs kubectl delete gateway -n $n | ||
| done |
There was a problem hiding this comment.
Do you need to clean service, deployment and grpcroutes and targetGroupPolicy?
mikhail-aws
force-pushed
the
e2e-cleanup
branch
from
bbc8ce8
to
8c1c1c0
Compare
Pull Request Test Coverage Report for Build 6153768735
💛 - Coveralls |
zijun726911
approved these changes
Sep 12, 2023
|
@zijun726911 changed default to e2e-tests. To use k8snamespace variable need to move it into different package. That will be too many changes for this PR, so I opted into hard coded value. |
zijun726911
approved these changes
Sep 12, 2023
erikfuller
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Tested with running, terminating, cleaning, and running again e2e-tests.
Closes #293
Closes #231