Skip to content

Commit

Permalink
feat(certificatemanager): key algorithm support for `PrivateCertifica…
Browse files Browse the repository at this point in the history
…te` and `Certificate` (#28597)

Add support for key algorithm when requesting a certificate

`keyAlgorithm` support for `DnsValidatedCertificate` is not supported since the construct was _deprecated_. Added a warning if user tries to use `keyAlgorithm` for the construct instead.

CloudFormation docs for [key algorithm](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-certificatemanager-certificate.html#cfn-certificatemanager-certificate-keyalgorithm).

Closes #22887.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
longtv2222 committed Jan 9, 2024
1 parent 3bf57de commit 1822cc9
Show file tree
Hide file tree
Showing 15 changed files with 755 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
{
"Resources": {
"ECprime256v1A2C983CE": {
"Type": "AWS::CertificateManager::Certificate",
"Properties": {
"DomainName": "*.example.com",
"DomainValidationOptions": [
{
"DomainName": "*.example.com",
"HostedZoneId": "Z23ABC4XYZL05B"
}
],
"KeyAlgorithm": "EC_prime256v1",
"Tags": [
{
"Key": "Name",
"Value": "integ-key-algorithm/EC_prime256v1"
}
],
"ValidationMethod": "DNS"
}
},
"ECsecp384r16CA95ECC": {
"Type": "AWS::CertificateManager::Certificate",
"Properties": {
"DomainName": "*.example.com",
"DomainValidationOptions": [
{
"DomainName": "*.example.com",
"HostedZoneId": "Z23ABC4XYZL05B"
}
],
"KeyAlgorithm": "EC_secp384r1",
"Tags": [
{
"Key": "Name",
"Value": "integ-key-algorithm/EC_secp384r1"
}
],
"ValidationMethod": "DNS"
}
},
"RSA2048CD164E12": {
"Type": "AWS::CertificateManager::Certificate",
"Properties": {
"DomainName": "*.example.com",
"DomainValidationOptions": [
{
"DomainName": "*.example.com",
"HostedZoneId": "Z23ABC4XYZL05B"
}
],
"KeyAlgorithm": "RSA_2048",
"Tags": [
{
"Key": "Name",
"Value": "integ-key-algorithm/RSA_2048"
}
],
"ValidationMethod": "DNS"
}
}
},
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
"Default": "/cdk-bootstrap/hnb659fds/version",
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
}
},
"Rules": {
"CheckBootstrapVersion": {
"Assertions": [
{
"Assert": {
"Fn::Not": [
{
"Fn::Contains": [
[
"1",
"2",
"3",
"4",
"5"
],
{
"Ref": "BootstrapVersion"
}
]
}
]
},
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
}
]
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1822cc9

Please sign in to comment.