fix(route53): delegation fails with public and private hosted zones w…

…ith same name (#30439) ### Issue # (if applicable) Closes #30262. ### Reason for this change Route53 does not support subdomain delegation on Private Hosted Zones ([source](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/hosted-zone-private-considerations.html#hosted-zone-private-considerations-delegating-subdomain)). `CrossAccountZoneDelegationRecord` should ignore Private Hosted Zones instead of throwing error. ### Description of changes In `CrossAccountZoneDelegationRecord` handler, filter out Private Hosted Zones. ### Description of how you validated changes Deployed a stack that uses the updated `CrossAccountZoneDelegationRecord` handler where the parent account has both public and private hosted zones with the same domain name. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws · Jun 11, 2024 · 1f866c9 · 1f866c9
1 parent e19d18b
commit 1f866c9
Show file tree

Hide file tree

Showing 24 changed files with 2,053 additions and 33 deletions.
diff --git a/...8472aa907dfa3021fed2bd6/__entrypoint__.js → ...1c2c38fadbf6f3e766cc87f/__entrypoint__.js b/...8472aa907dfa3021fed2bd6/__entrypoint__.js → ...1c2c38fadbf6f3e766cc87f/__entrypoint__.js
diff --git a/....snapshot/asset.862d20f925bec1059342f4a1a7717b3c20bd77ffd1c2c38fadbf6f3e766cc87f/index.js b/....snapshot/asset.862d20f925bec1059342f4a1a7717b3c20bd77ffd1c2c38fadbf6f3e766cc87f/index.js
diff --git a/...8472aa907dfa3021fed2bd6/__entrypoint__.js → ...5005114dd60342e0b8a85a1/__entrypoint__.js b/...8472aa907dfa3021fed2bd6/__entrypoint__.js → ...5005114dd60342e0b8a85a1/__entrypoint__.js
diff --git a/....snapshot/asset.bde7b5c89cb43285f884c94f0b9e17cdb0f5eb5345005114dd60342e0b8a85a1/index.js b/....snapshot/asset.bde7b5c89cb43285f884c94f0b9e17cdb0f5eb5345005114dd60342e0b8a85a1/index.js
diff --git a/...ccount-zone-delegation.js.snapshot/child-opt-in-stack-with-assume-role-region.assets.json b/...ccount-zone-delegation.js.snapshot/child-opt-in-stack-with-assume-role-region.assets.json
diff --git a/...ount-zone-delegation.js.snapshot/child-opt-in-stack-with-assume-role-region.template.json b/...ount-zone-delegation.js.snapshot/child-opt-in-stack-with-assume-role-region.template.json
@@ -104,7 +104,7 @@
    "Properties": {
     "Code": {
      "S3Bucket": "cdk-hnb659fds-assets-234567890123-af-south-1",
-     "S3Key": "df3b0c6a1a1c298cd483caec10a008f70e053a49a8472aa907dfa3021fed2bd6.zip"
+     "S3Key": "862d20f925bec1059342f4a1a7717b3c20bd77ffd1c2c38fadbf6f3e766cc87f.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,

diff --git a/...ute53/test/integ.cross-account-zone-delegation.js.snapshot/child-opt-in-stack.assets.json b/...ute53/test/integ.cross-account-zone-delegation.js.snapshot/child-opt-in-stack.assets.json
diff --git a/...e53/test/integ.cross-account-zone-delegation.js.snapshot/child-opt-in-stack.template.json b/...e53/test/integ.cross-account-zone-delegation.js.snapshot/child-opt-in-stack.template.json
@@ -103,7 +103,7 @@
    "Properties": {
     "Code": {
      "S3Bucket": "cdk-hnb659fds-assets-234567890123-af-south-1",
-     "S3Key": "df3b0c6a1a1c298cd483caec10a008f70e053a49a8472aa907dfa3021fed2bd6.zip"
+     "S3Key": "862d20f925bec1059342f4a1a7717b3c20bd77ffd1c2c38fadbf6f3e766cc87f.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,

diff --git a/.../aws-route53/test/integ.cross-account-zone-delegation.js.snapshot/child-stack.assets.json b/.../aws-route53/test/integ.cross-account-zone-delegation.js.snapshot/child-stack.assets.json
diff --git a/...ws-route53/test/integ.cross-account-zone-delegation.js.snapshot/child-stack.template.json b/...ws-route53/test/integ.cross-account-zone-delegation.js.snapshot/child-stack.template.json
@@ -103,7 +103,7 @@
    "Properties": {
     "Code": {
      "S3Bucket": "cdk-hnb659fds-assets-234567890123-us-east-1",
-     "S3Key": "df3b0c6a1a1c298cd483caec10a008f70e053a49a8472aa907dfa3021fed2bd6.zip"
+     "S3Key": "862d20f925bec1059342f4a1a7717b3c20bd77ffd1c2c38fadbf6f3e766cc87f.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,