refactor: set default value enum

aws · May 12, 2024 · 6d610e6 · 6d610e6
1 parent 402d5b9
commit 6d610e6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/...sting/framework-integ/test/aws-batch/test/integ.job-queue-job-state-time-limit-actions.ts b/...sting/framework-integ/test/aws-batch/test/integ.job-queue-job-state-time-limit-actions.ts
@@ -29,10 +29,8 @@ new batch.JobQueue(stack, 'joBBQ', {
       state: batch.JobStateTimeLimitActionsState.RUNNABLE,
     },
     {
-      action: batch.JobStateTimeLimitActionsAction.CANCEL,
       maxTimeSeconds: Duration.minutes(10),
       reason: batch.JobStateTimeLimitActionsReason.JOB_RESOURCE_REQUIREMENT,
-      state: batch.JobStateTimeLimitActionsState.RUNNABLE,
     },
   ],
 });

diff --git a/packages/aws-cdk-lib/aws-batch/lib/job-queue.ts b/packages/aws-cdk-lib/aws-batch/lib/job-queue.ts
@@ -152,8 +152,10 @@ export interface JobStateTimeLimitAction {
   /**
  * The action to take when a job is at the head of the job queue in the specified state
  * for the specified period of time.
+ *
+ * @default JobStateTimeLimitActionsAction.CANCEL
  */
-  readonly action: JobStateTimeLimitActionsAction;
+  readonly action?: JobStateTimeLimitActionsAction;
 
   /**
    * The approximate amount of time, in seconds, that must pass with the job in the specified
@@ -170,8 +172,10 @@ export interface JobStateTimeLimitAction {
 
   /**
    * The state of the job needed to trigger the action.
+   *
+   * @default JobStateTimeLimitActionsState.RUNNABLE
    */
-  readonly state: JobStateTimeLimitActionsState;
+  readonly state?: JobStateTimeLimitActionsState;
 }
 
 /**
@@ -304,10 +308,10 @@ export class JobQueue extends Resource implements IJobQueue {
       }
 
       return {
-        action: jobStateTimeLimitAction.action,
+        action: jobStateTimeLimitAction.action ?? JobStateTimeLimitActionsAction.CANCEL,
         maxTimeSeconds,
         reason: jobStateTimeLimitAction.reason,
-        state: jobStateTimeLimitAction.state,
+        state: jobStateTimeLimitAction.state ?? JobStateTimeLimitActionsState.RUNNABLE,
       };
     }
   }

diff --git a/packages/aws-cdk-lib/aws-batch/test/job-queue.test.ts b/packages/aws-cdk-lib/aws-batch/test/job-queue.test.ts
@@ -287,10 +287,8 @@ test('JobQueue with JobStateTimeLimitActions', () => {
         state: JobStateTimeLimitActionsState.RUNNABLE,
       },
       {
-        action: JobStateTimeLimitActionsAction.CANCEL,
         maxTimeSeconds: Duration.minutes(10),
         reason: JobStateTimeLimitActionsReason.JOB_RESOURCE_REQUIREMENT,
-        state: JobStateTimeLimitActionsState.RUNNABLE,
       },
     ],
   });