Skip to content

Commit

Permalink
fix(apigateway): json schema additionalProperties should be boolean (#…
Browse files Browse the repository at this point in the history
…3997)

* Add support for json schema additionalProperties

* Change it to boolean according to code review

* add breaking change exclusions
  • Loading branch information
daiwei920 authored and mergify[bot] committed Sep 11, 2019
1 parent 21eed2d commit 73a1de1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions allowed-breaking-changes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ incompatible-argument:@aws-cdk/aws-lambda.Function.<initializer>
incompatible-argument:@aws-cdk/aws-lambda.SingletonFunction.<initializer>
incompatible-argument:@aws-cdk/aws-lambda.Function.addEnvironment
changed-type:@aws-cdk/aws-dynamodb.Table.tableStreamArn
incompatible-argument:@aws-cdk/aws-apigateway.LambdaRestApi.addModel
incompatible-argument:@aws-cdk/aws-apigateway.Model.<initializer>
incompatible-argument:@aws-cdk/aws-apigateway.RestApi.addModel
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-apigateway/lib/json-schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export interface JsonSchema {
readonly minProperties?: number;
readonly required?: string[];
readonly properties?: { [name: string]: JsonSchema };
readonly additionalProperties?: JsonSchema;
readonly additionalProperties?: boolean;
readonly patternProperties?: { [name: string]: JsonSchema };
readonly dependencies?: { [name: string]: JsonSchema | string[] };
readonly propertyNames?: JsonSchema;
Expand Down

0 comments on commit 73a1de1

Please sign in to comment.