add feedback from Luca

aws · Jan 9, 2024 · 885f0c9 · 885f0c9
1 parent ee67f9e
commit 885f0c9
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/...s-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.ec2-run-task.ts b/...s-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.ec2-run-task.ts
@@ -66,7 +66,7 @@ new cdk.CfnOutput(stack, 'stateMachineArn', {
   value: sm.stateMachineArn,
 });
 
-new IntegTest(app, 'EmrCreateClusterTest', {
+new IntegTest(app, 'SfnTasksEcsEc2RunTaskTest', {
   testCases: [stack],
 });
 

diff --git a/.../@aws-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.ec2-task.ts b/.../@aws-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.ec2-task.ts
@@ -63,7 +63,7 @@ new sfn.StateMachine(stack, 'StateMachine', {
   definition,
 });
 
-new IntegTest(app, 'EmrCreateClusterTest', {
+new IntegTest(app, 'SfnTasksEcsEc2TaskTest', {
   testCases: [stack],
 });
 

diff --git a/...k-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.fargate-run-task.ts b/...k-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.fargate-run-task.ts
@@ -86,7 +86,7 @@ new cdk.CfnOutput(stack, 'stateMachineArn', {
   value: sm.stateMachineArn,
 });
 
-new IntegTest(app, 'EmrCreateClusterTest', {
+new IntegTest(app, 'SfnTasksEcsFargateRunTaskTest', {
   testCases: [stack],
 });
 

diff --git a/...s-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.fargate-task.ts b/...s-cdk-testing/framework-integ/test/aws-stepfunctions-tasks/test/ecs/integ.fargate-task.ts
@@ -62,7 +62,7 @@ new sfn.StateMachine(stack, 'StateMachine', {
   definition,
 });
 
-new IntegTest(app, 'EmrCreateClusterTest', {
+new IntegTest(app, 'SfnTasksEcsFargateTaskTest', {
   testCases: [stack],
 });
 

diff --git a/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-task.ts b/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/ecs/run-task.ts
@@ -337,12 +337,13 @@ export class EcsRunTask extends sfn.TaskStateBase implements ec2.IConnectable {
     const stack = cdk.Stack.of(this);
 
     // https://docs.aws.amazon.com/step-functions/latest/dg/ecs-iam.html
+    const taskDefinitionFamilyArn = this.getTaskDefinitionFamilyArn();
     const policyStatements = [
       new iam.PolicyStatement({
         actions: ['ecs:RunTask'],
         resources: [
-          this.getTaskDefinitionFamilyArn(),
-          `${this.getTaskDefinitionFamilyArn()}:*`,
+          taskDefinitionFamilyArn,
+          `${taskDefinitionFamilyArn}:*`,
         ],
       }),
       new iam.PolicyStatement({