chore: more style rules for eslint (#9517)

Configure `comma-spacing`, `no-multi-spaces`, `array-bracket-spacing`,
`array-bracket-newline`, `object-curly-spacing`, `object-curly-newline` and
`object-property-newline` to uniformize arrays and objects.

* Valid arrays (no bracket spacing, no space before comma, a single space after
comma):

```ts
[1, 2, 3]

[
  1,
  2,
  3,
]

[
  1, 2,
  3, 4,
]
```
* Valid objects (curly spacing):

```ts
{ key: 'value' }

{ key1: 'value1', key2: 'value2 }

{
  key1: 'value1',
  key2: 'value2',
}
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

packages/@aws-cdk/app-delivery/test/test.pipeline-deploy-stack-action.ts

@@ -504,7 +504,7 @@ function createSelfUpdatingStack(pipelineStack: cdk.Stack): SelfUpdatingPipeline
     stageName: 'build',
     actions: [buildAction],
   });
-  return {synthesizedApp: buildOutput, pipeline};
+  return { synthesizedApp: buildOutput, pipeline };
 }
 
 function hasPipelineAction(expectedAction: any): (props: any) => boolean {

packages/@aws-cdk/assert/test/assertions.test.ts

@@ -92,8 +92,8 @@ passingExample('expect <synthStack> to be a superset of <template> with paramete
     // Added
     new TestResource(stack, 'NewResource', { type: 'AWS::S3::Bucket' });
     // Expected
-    new TestParameter(stack, 'TestParameterA', {type: parameterType});
-    new TestParameter(stack, 'TestParameterB', {type: parameterType, default: { Foo: 'Bar' } });
+    new TestParameter(stack, 'TestParameterA', { type: parameterType });
+    new TestParameter(stack, 'TestParameterB', { type: parameterType, default: { Foo: 'Bar' } });
   });
   const expected = {
     Parameters: {
@@ -261,7 +261,7 @@ passingExample('expect <stack> to count resources like props - expected no resou
   const synthStack = synthesizedStack(stack => {
     new TestResource(stack, 'R1', { type: resourceType, properties: { parentId: 123, name: 'A' } });
     new TestResource(stack, 'R2', { type: resourceType });
-    new TestResource(stack, 'R3', { type: 'Foo', properties: { parentId: 456} });
+    new TestResource(stack, 'R3', { type: 'Foo', properties: { parentId: 456 } });
   });
   cdkExpect(synthStack).to(countResourcesLike(resourceType, 0, { parentId: 456 }));
 });

packages/@aws-cdk/assert/test/have-output.test.ts

@@ -164,7 +164,7 @@ test('haveOutput should throw Error when none of outputName and exportName is pr
 
 test('haveOutput should be able to handle complex exportName values', () => {
   expect(synthStack).toHaveOutput({
-    exportName: {'Fn::Sub': '${AWS::StackName}-ComplexExportNameOutput'},
+    exportName: { 'Fn::Sub': '${AWS::StackName}-ComplexExportNameOutput' },
     outputValue: {
       'Fn::GetAtt': [
         'ComplexOutputResource',

packages/@aws-cdk/assets/test/test.staging.ts

@@ -1,8 +1,8 @@
+import * as fs from 'fs';
+import * as path from 'path';
 import { App, Stack } from '@aws-cdk/core';
 import * as cxapi from '@aws-cdk/cx-api';
-import * as fs from 'fs';
 import { Test } from 'nodeunit';
-import * as path from 'path';
 import { Staging } from '../lib';
 
 export = {

packages/@aws-cdk/aws-apigateway/lib/access-log.ts

@@ -504,10 +504,10 @@ export class AccessLogFormat {
    * Generate Common Log Format.
    */
   public static clf(): AccessLogFormat {
-    const requester = [AccessLogField.contextIdentitySourceIp(), AccessLogField.contextIdentityCaller(), AccessLogField.contextIdentityUser() ].join(' ');
+    const requester = [AccessLogField.contextIdentitySourceIp(), AccessLogField.contextIdentityCaller(), AccessLogField.contextIdentityUser()].join(' ');
     const requestTime = AccessLogField.contextRequestTime();
-    const request = [ AccessLogField.contextHttpMethod(), AccessLogField.contextResourcePath(), AccessLogField.contextProtocol()].join(' ');
-    const status = [ AccessLogField.contextStatus(), AccessLogField.contextResponseLength(), AccessLogField.contextRequestId()].join(' ');
+    const request = [AccessLogField.contextHttpMethod(), AccessLogField.contextResourcePath(), AccessLogField.contextProtocol()].join(' ');
+    const status = [AccessLogField.contextStatus(), AccessLogField.contextResponseLength(), AccessLogField.contextRequestId()].join(' ');
 
     return new AccessLogFormat(`${requester} [${requestTime}] "${request}" ${status}`);
   }

packages/@aws-cdk/aws-apigateway/lib/apigatewayv2.ts

@@ -321,7 +321,7 @@ export class CfnApiV2 extends cdk.CfnResource implements cdk.IInspectable {
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiKeySelectionExpression: this.apiKeySelectionExpression,
       basePath: this.basePath,
@@ -341,7 +341,7 @@ export class CfnApiV2 extends cdk.CfnResource implements cdk.IInspectable {
       version: this.version,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnApiV2PropsToCloudFormation(props);
   }
 }
@@ -640,15 +640,15 @@ export class CfnApiMappingV2 extends cdk.CfnResource implements cdk.IInspectable
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       domainName: this.domainName,
       stage: this.stage,
       apiMappingKey: this.apiMappingKey,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnApiMappingV2PropsToCloudFormation(props);
   }
 }
@@ -872,7 +872,7 @@ export class CfnAuthorizerV2 extends cdk.CfnResource implements cdk.IInspectable
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       authorizerType: this.authorizerType,
@@ -885,7 +885,7 @@ export class CfnAuthorizerV2 extends cdk.CfnResource implements cdk.IInspectable
       jwtConfiguration: this.jwtConfiguration,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnAuthorizerV2PropsToCloudFormation(props);
   }
 }
@@ -1068,14 +1068,14 @@ export class CfnDeploymentV2 extends cdk.CfnResource implements cdk.IInspectable
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       description: this.description,
       stageName: this.stageName,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnDeploymentV2PropsToCloudFormation(props);
   }
 }
@@ -1215,14 +1215,14 @@ export class CfnDomainNameV2 extends cdk.CfnResource implements cdk.IInspectable
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       domainName: this.domainName,
       domainNameConfigurations: this.domainNameConfigurations,
       tags: this.tags.renderTags(),
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnDomainNameV2PropsToCloudFormation(props);
   }
 }
@@ -1579,7 +1579,7 @@ export class CfnIntegrationV2 extends cdk.CfnResource implements cdk.IInspectabl
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       integrationType: this.integrationType,
@@ -1597,7 +1597,7 @@ export class CfnIntegrationV2 extends cdk.CfnResource implements cdk.IInspectabl
       timeoutInMillis: this.timeoutInMillis,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnIntegrationV2PropsToCloudFormation(props);
   }
 }
@@ -1789,7 +1789,7 @@ export class CfnIntegrationResponseV2 extends cdk.CfnResource implements cdk.IIn
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       integrationId: this.integrationId,
@@ -1800,7 +1800,7 @@ export class CfnIntegrationResponseV2 extends cdk.CfnResource implements cdk.IIn
       templateSelectionExpression: this.templateSelectionExpression,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnIntegrationResponseV2PropsToCloudFormation(props);
   }
 }
@@ -1962,7 +1962,7 @@ export class CfnModelV2 extends cdk.CfnResource implements cdk.IInspectable {
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       name: this.name,
@@ -1971,7 +1971,7 @@ export class CfnModelV2 extends cdk.CfnResource implements cdk.IInspectable {
       description: this.description,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnModelV2PropsToCloudFormation(props);
   }
 }
@@ -2236,7 +2236,7 @@ export class CfnRouteV2 extends cdk.CfnResource implements cdk.IInspectable {
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       routeKey: this.routeKey,
@@ -2252,7 +2252,7 @@ export class CfnRouteV2 extends cdk.CfnResource implements cdk.IInspectable {
       target: this.target,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnRouteV2PropsToCloudFormation(props);
   }
 }
@@ -2478,7 +2478,7 @@ export class CfnRouteResponseV2 extends cdk.CfnResource implements cdk.IInspecta
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       routeId: this.routeId,
@@ -2488,7 +2488,7 @@ export class CfnRouteResponseV2 extends cdk.CfnResource implements cdk.IInspecta
       responseParameters: this.responseParameters,
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnRouteResponseV2PropsToCloudFormation(props);
   }
 }
@@ -2787,7 +2787,7 @@ export class CfnStageV2 extends cdk.CfnResource implements cdk.IInspectable {
     inspector.addAttribute('aws:cdk:cloudformation:props', this.cfnProperties);
   }
 
-  protected get cfnProperties(): { [key: string]: any }  {
+  protected get cfnProperties(): { [key: string]: any } {
     return {
       apiId: this.apiId,
       stageName: this.stageName,
@@ -2802,7 +2802,7 @@ export class CfnStageV2 extends cdk.CfnResource implements cdk.IInspectable {
       tags: this.tags.renderTags(),
     };
   }
-  protected renderProperties(props: {[key: string]: any}): { [key: string]: any }  {
+  protected renderProperties(props: {[key: string]: any}): { [key: string]: any } {
     return cfnStageV2PropsToCloudFormation(props);
   }
 }

packages/@aws-cdk/aws-apigateway/lib/authorizers/lambda.ts

@@ -104,8 +104,8 @@ abstract class LambdaAuthorizer extends Authorizer implements IAuthorizer {
       this.role.attachInlinePolicy(new iam.Policy(this, 'authorizerInvokePolicy', {
         statements: [
           new iam.PolicyStatement({
-            resources: [ this.handler.functionArn ],
-            actions: [ 'lambda:InvokeFunction' ],
+            resources: [this.handler.functionArn],
+            actions: ['lambda:InvokeFunction'],
           }),
         ],
       }));

packages/@aws-cdk/aws-apigateway/lib/cors.ts

@@ -104,12 +104,12 @@ export class Cors {
   /**
    * All origins.
    */
-  public static readonly ALL_ORIGINS = [ '*' ];
+  public static readonly ALL_ORIGINS = ['*'];
 
   /**
    * The set of default headers allowed for CORS and useful for API Gateway.
    */
-  public static readonly DEFAULT_HEADERS = [ 'Content-Type', 'X-Amz-Date', 'Authorization', 'X-Api-Key', 'X-Amz-Security-Token', 'X-Amz-User-Agent' ];
+  public static readonly DEFAULT_HEADERS = ['Content-Type', 'X-Amz-Date', 'Authorization', 'X-Api-Key', 'X-Amz-Security-Token', 'X-Amz-User-Agent'];
 
   // utility class
   private constructor() { }

packages/@aws-cdk/aws-apigateway/lib/deployment.ts

@@ -1,10 +1,10 @@
 import * as crypto from 'crypto';
 import { Construct, Lazy, RemovalPolicy, Resource, CfnResource } from '@aws-cdk/core';
 import { CfnDeployment } from './apigateway.generated';
-import { IRestApi, RestApi, SpecRestApi, RestApiBase } from './restapi';
 import { Method } from './method';
+import { IRestApi, RestApi, SpecRestApi, RestApiBase } from './restapi';
 
-export interface DeploymentProps  {
+export interface DeploymentProps {
   /**
    * The Rest API to deploy.
    */
@@ -158,7 +158,7 @@ class LatestDeploymentResource extends CfnDeployment {
   }
 
   private calculateLogicalId() {
-    const hash = [ ...this.hashComponents ];
+    const hash = [...this.hashComponents];
 
     if (this.api instanceof RestApi || this.api instanceof SpecRestApi) { // Ignore IRestApi that are imported
 

packages/@aws-cdk/aws-apigateway/lib/integrations/aws.ts

@@ -78,16 +78,18 @@ export class AwsIntegration extends Integration {
     super({
       type,
       integrationHttpMethod: props.integrationHttpMethod || 'POST',
-      uri: cdk.Lazy.stringValue({ produce: () => {
-        if (!this.scope) { throw new Error('AwsIntegration must be used in API'); }
-        return cdk.Stack.of(this.scope).formatArn({
-          service: 'apigateway',
-          account: backend,
-          resource: apiType,
-          sep: '/',
-          resourceName: apiValue,
-        });
-      }}),
+      uri: cdk.Lazy.stringValue({
+        produce: () => {
+          if (!this.scope) { throw new Error('AwsIntegration must be used in API'); }
+          return cdk.Stack.of(this.scope).formatArn({
+            service: 'apigateway',
+            account: backend,
+            resource: apiType,
+            sep: '/',
+            resourceName: apiValue,
+          });
+        },
+      }),
       options: props.options,
     });
   }

packages/@aws-cdk/aws-apigateway/lib/resource.ts

@@ -283,7 +283,7 @@ export abstract class ResourceBase extends ResourceConstruct implements IResourc
     const integrationResponseParams: { [p: string]: string } = { };
     const methodReponseParams: { [p: string]: boolean } = { };
 
-    for (const [ name, value ] of Object.entries(headers)) {
+    for (const [name, value] of Object.entries(headers)) {
       const key = `method.response.header.${name}`;
       integrationResponseParams[key] = value;
       methodReponseParams[key] = true;

packages/@aws-cdk/aws-apigateway/lib/restapi.ts

@@ -689,7 +689,7 @@ export class RestApi extends RestApiBase {
    */
   protected validate() {
     if (this.methods.length === 0) {
-      return [ "The REST API doesn't contain any methods" ];
+      return ["The REST API doesn't contain any methods"];
     }
 
     return [];

packages/@aws-cdk/aws-apigateway/lib/stage.ts

@@ -1,5 +1,5 @@
 import { Construct, Duration, IResource, Resource, Stack } from '@aws-cdk/core';
-import { AccessLogFormat, IAccessLogDestination} from './access-log';
+import { AccessLogFormat, IAccessLogDestination } from './access-log';
 import { CfnStage } from './apigateway.generated';
 import { Deployment } from './deployment';
 import { IRestApi } from './restapi';
@@ -305,7 +305,8 @@ export class Stage extends Resource implements IStage {
       const { httpMethod, resourcePath } = parseMethodOptionsPath(path);
 
       return {
-        httpMethod, resourcePath,
+        httpMethod,
+        resourcePath,
         cacheDataEncrypted: options.cacheDataEncrypted,
         cacheTtlInSeconds: options.cacheTtl && options.cacheTtl.toSeconds(),
         cachingEnabled: options.cachingEnabled,

packages/@aws-cdk/aws-apigateway/lib/util.ts

@@ -1,9 +1,9 @@
 import { format as formatUrl } from 'url';
 import * as jsonSchema from './json-schema';
 
-export const ALL_METHODS = [ 'OPTIONS', 'GET', 'PUT', 'POST', 'DELETE', 'PATCH', 'HEAD' ];
+export const ALL_METHODS = ['OPTIONS', 'GET', 'PUT', 'POST', 'DELETE', 'PATCH', 'HEAD'];
 
-const ALLOWED_METHODS = [ 'ANY', ...ALL_METHODS ];
+const ALLOWED_METHODS = ['ANY', ...ALL_METHODS];
 
 export function validateHttpMethod(method: string, messagePrefix: string = '') {
   if (!ALLOWED_METHODS.includes(method)) {

packages/@aws-cdk/aws-apigateway/lib/vpc-link.ts

@@ -87,7 +87,7 @@ export class VpcLink extends Resource implements IVpcLink {
 
   protected validate(): string[] {
     if (this.targets.length === 0) {
-      return [ 'No targets added to vpc link' ];
+      return ['No targets added to vpc link'];
     }
     return [];
   }