change default test behavior to ignore deprecations

aws · Jun 13, 2023 · a90c06c · a90c06c
1 parent d408636
commit a90c06c
Show file tree

Hide file tree

Showing 11 changed files with 3 additions and 24 deletions.
diff --git a/packages/@aws-cdk/region-info/test/default.test.ts b/packages/@aws-cdk/region-info/test/default.test.ts
@@ -1,7 +1,5 @@
 import { Default } from '../lib';
 
-process.env.JSII_DEPRECATED = 'quiet';
-
 const region = 'bermuda-triangle-42';
 const urlSuffix = '.nowhere.null';
 

diff --git a/packages/@aws-cdk/region-info/test/fact.test.ts b/packages/@aws-cdk/region-info/test/fact.test.ts
@@ -1,8 +1,6 @@
 import { Fact, FactName } from '../lib';
 import { AWS_REGIONS } from '../lib/aws-entities';
 
-process.env.JSII_DEPRECATED = 'quiet';
-
 describe('find', () => {
   test('returns undefined for an unknown fact', () => {
     expect(Fact.find(AWS_REGIONS[0], 'not:a:known:fact')).toBe(undefined);

diff --git a/packages/@aws-cdk/region-info/test/region-info.test.ts b/packages/@aws-cdk/region-info/test/region-info.test.ts
@@ -2,8 +2,6 @@ import { CLOUDWATCH_LAMBDA_INSIGHTS_ARNS } from '../build-tools/fact-tables';
 import { FactName, RegionInfo } from '../lib';
 import { AWS_REGIONS, AWS_SERVICES } from '../lib/aws-entities';
 
-process.env.JSII_DEPRECATED = 'quiet';
-
 test('built-in data is correct', () => {
   const snapshot: any = {};
   for (const name of AWS_REGIONS) {

diff --git a/packages/cdk-cli-wrapper/test/cdk-wrapper.test.ts b/packages/cdk-cli-wrapper/test/cdk-wrapper.test.ts
@@ -4,8 +4,6 @@ import { RequireApproval } from '../lib/commands';
 let spawnSyncMock: jest.SpyInstance;
 
 beforeEach(() => {
-  process.env.JSII_DEPRECATED = 'silent';
-
   spawnSyncMock = jest.spyOn(child_process, 'spawnSync').mockReturnValue({
     status: 0,
     stderr: Buffer.from('stderr'),

diff --git a/tools/@aws-cdk/cdk-build-tools/bin/cdk-test.ts b/tools/@aws-cdk/cdk-build-tools/bin/cdk-test.ts
@@ -35,9 +35,7 @@ async function main() {
     env: {
       ...defaultShellOptions.env,
 
-      // by default, fail when deprecated symbols are used in tests.
-      // tests that verify behaviour of deprecated symbols must use the `testDeprecated()` API.
-      JSII_DEPRECATED: 'fail',
+      JSII_DEPRECATED: 'quiet',
     },
   };
 

diff --git a/tools/@aws-cdk/eslint-plugin/lib/rules/invalid-cfn-imports.ts b/tools/@aws-cdk/eslint-plugin/lib/rules/invalid-cfn-imports.ts
@@ -151,7 +151,7 @@ function isAlphaPackage(packageDir: string): boolean {
   }
 
   const maturity = pkg.maturity;
-  if (maturity !== 'experimental' && maturity !== 'developer-preview' && maturity !== 'deprecated') {
+  if (maturity !== 'experimental' && maturity !== 'developer-preview') {
     return false;
   }
   // we're only interested in '@aws-cdk/' packages,

diff --git a/.../@aws-cdk/eslint-plugin/test/rules/fixtures/invalid-cfn-imports/cfn-constructor.error.txt b/.../@aws-cdk/eslint-plugin/test/rules/fixtures/invalid-cfn-imports/cfn-constructor.error.txt
diff --git a/tools/@aws-cdk/eslint-plugin/test/rules/fixtures/invalid-cfn-imports/cfn-constructor.ts b/tools/@aws-cdk/eslint-plugin/test/rules/fixtures/invalid-cfn-imports/cfn-constructor.ts
diff --git a/...est/rules/fixtures/invalid-cfn-imports/reference-cfn-construct-on-barrel-import.error.txt b/...est/rules/fixtures/invalid-cfn-imports/reference-cfn-construct-on-barrel-import.error.txt
diff --git a/...lugin/test/rules/fixtures/invalid-cfn-imports/reference-cfn-construct-on-barrel-import.ts b/...lugin/test/rules/fixtures/invalid-cfn-imports/reference-cfn-construct-on-barrel-import.ts
diff --git a/tools/@aws-cdk/node-bundle/test/cli.test.ts b/tools/@aws-cdk/node-bundle/test/cli.test.ts
@@ -1,7 +1,7 @@
 import * as path from 'path';
 import * as fs from 'fs-extra';
-import { shell } from '../src/api/_shell';
 import { Package } from './_package';
+import { shell } from '../src/api/_shell';
 
 test('validate', () => {