Skip to content

Commit

Permalink
chore: turn off prerequisite check for Gitpod (#9113)
Browse files Browse the repository at this point in the history
Gitpod doesn't have a running Docker demon currently,
so the check fails for it.
However, it uses jsii/superchain,
so it's guaranteed to have all of the other required tools.
So, just skip the check for it completely.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
skinny85 committed Jul 16, 2020
1 parent 8d470b2 commit bb95957
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .gitpod.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image: jsii/superchain
tasks:
- init: yarn build --skip-test --no-bail
- init: yarn build --skip-test --no-bail --skip-prereqs

vscode:
extensions:
Expand Down
10 changes: 8 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ set -euo pipefail

bail="--bail"
runtarget="build+test"
check_prereqs="true"
while [[ "${1:-}" != "" ]]; do
case $1 in
-h|--help)
Expand All @@ -18,6 +19,9 @@ while [[ "${1:-}" != "" ]]; do
--skip-test|--skip-tests)
runtarget="build"
;;
--skip-prereqs)
check_prereqs="false"
;;
*)
echo "Unrecognized parameter: $1"
exit 1
Expand All @@ -41,8 +45,10 @@ fail() {
# Check for secrets that should not be committed
/bin/bash ./git-secrets-scan.sh

# Verify dependencies before starting the build
/bin/bash ./scripts/check-prerequisites.sh
# Verify all required tools are present before starting the build
if [ "$check_prereqs" == "true" ]; then
/bin/bash ./scripts/check-prerequisites.sh
fi

# Prepare for build with references
/bin/bash scripts/generate-aggregate-tsconfig.sh > tsconfig.json
Expand Down

0 comments on commit bb95957

Please sign in to comment.