Apply suggestions from code review

Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
aws · Mar 6, 2023 · c198aeb · c198aeb
1 parent 3f79c30
commit c198aeb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/@aws-cdk/custom-resources/test/aws-custom-resource/aws-custom-resource.test.ts b/packages/@aws-cdk/custom-resources/test/aws-custom-resource/aws-custom-resource.test.ts
@@ -414,7 +414,7 @@ describe('physicalResourceId patterns', () => {
   });
 
   // physicalResourceId pattern #7
-  test('physicalResourceId is specified in onUpdate with empty onCreate then success', () => {
+  test('onCreate and onUpdate both have physicalResourceId when physicalResourceId is specified in onUpdate, even when onCreate is unspecified', () => {
     // GIVEN
     const stack = new cdk.Stack();
 
@@ -460,7 +460,7 @@ describe('physicalResourceId patterns', () => {
   });
 
   // physicalResourceId pattern #8
-  test('physicalResourceId is not specified onCreate with empty onUpdate then fail', () => {
+  test('Omitting physicalResourceId in onCreate when onUpdate is undefined throws an error', () => {
     // GIVEN
     const stack = new cdk.Stack();
 
@@ -478,7 +478,7 @@ describe('physicalResourceId patterns', () => {
         },
         policy: AwsCustomResourcePolicy.fromSdkCalls({ resources: AwsCustomResourcePolicy.ANY_RESOURCE }),
       });
-    }).toThrow(/`physicalResourceId` must be specified for onUpdate call when onCreate is omitted./);
+    }).toThrow(/'physicalResourceId' must be specified for 'onUpdate' call when 'onCreate' is omitted./);
   });
 });