Skip to content

Commit

Permalink
chore: rewrite "updating all dependencies" section in contribution gu…
Browse files Browse the repository at this point in the history
…ide (#2172)
  • Loading branch information
Elad Ben-Israel committed Apr 3, 2019
1 parent aa6f7bc commit ccbb6dd
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -355,18 +355,12 @@ Cycle: @aws-cdk/aws-sns => @aws-cdk/aws-lambda => @aws-cdk/aws-codecommit => @aw

### Updating all Dependencies

We use `npm update` to

1. Obtain a fresh clone from “master”
2. Run `./install.sh` and `./build.sh` to make sure the current HEAD is not broken (should never be...).
3. Once build succeeded, run:
```shell
$ npm update # to update the root deps
$ lerna exec npm update # to update deps in all modules
```
4. This will probably install some new versions and update `package.json` and `package-lock.json` files.
5. Now, run `./build.sh` again to verify all tests pass.
6. Submit a Pull Request.
To update all dependencies (without bumping major versions):

1. Obtain a fresh clone from "master".
2. Run `./install.sh`
2. Run `./scripts/update-dependencies.sh --mode full` (use `--mode semver` to avoid bumping major versions)
3. Submit a Pull Request.

### Troubleshooting common issues

Expand Down

0 comments on commit ccbb6dd

Please sign in to comment.