Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudfront): support includeBody for Lambda@Edge #10008

Merged
merged 5 commits into from
Aug 28, 2020
Merged

feat(cloudfront): support includeBody for Lambda@Edge #10008

merged 5 commits into from
Aug 28, 2020

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Aug 27, 2020

The includeBody flag enables a Lambda@Edge function to receive the body of the
request or response. Enabled this flag for both the CloudFrontWebDistribution
and Distribution constructs.

fixes #7085

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@njlynch
feat(cloudfront): support for includeBody for Lambda@Edge
b793a25 
The `includeBody` flag enables a Lambda@Edge function to receive the body of the
request or response. Enabled this flag for both the `CloudFrontWebDistribution`
and `Distribution` constructs.

fixes #7085
@njlynch njlynch requested a review from a team August 27, 2020 13:15
@njlynch njlynch self-assigned this Aug 27, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 27, 2020
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Aug 28, 2020
rix0rrr
rix0rrr approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally approved modulo parameter validation

@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Aug 28, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d6ac2a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9ffb268 into master Aug 28, 2020
@mergify mergify bot deleted the njlynch/cf-lambda-include-body branch August 28, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogold jogold jogold left review comments

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@njlynch njlynch

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support include body for LambdaFunctionAssociation
4 participants
@njlynch @aws-cdk-automation @rix0rrr @jogold