Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@aws-cdk/custom-resources] Unreliable tests always fails on second test run #10017

Closed
nathanpeck opened this issue Aug 27, 2020 · 1 comment · Fixed by #9977
Closed

[@aws-cdk/custom-resources] Unreliable tests always fails on second test run #10017

nathanpeck opened this issue Aug 27, 2020 · 1 comment · Fixed by #9977
Assignees
@rix0rrr
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources bug This issue is a bug. effort/small Small work item – less than a day of effort needs-triage This issue or PR still needs to be triaged.

Comments

@nathanpeck
Copy link
Member

The build and test runs the first time, but always fails on a subsequent run.

Reproduction Steps

Run yarn build+test twice.

What did you expect to happen?

Expected the tests to pass the second time just like they did the first time.

What actually happened?

Tests fail with the following message:

@aws-cdk/custom-resources: FAIL test/aws-custom-resource/aws-custom-resource-provider.test.js
@aws-cdk/custom-resources:   ● installs the latest SDK
@aws-cdk/custom-resources:     EEXIST: file already exists, symlink '/home/ubuntu/environment/aws-cdk/node_modules/aws-sdk/lib/aws.js' -> '/tmp/node_modules/aws-sdk'

This can be mitigated by running rm -rf /tmp/* to clear the created file out of the /tmp folder.

Recommend making the test clean up its own state before its test runs, or determine if there is a deeper bug in the implementation here

This is 🐛 Bug Report
@nathanpeck nathanpeck added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 27, 2020
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Aug 27, 2020
@jogold
Copy link
Contributor

jogold commented Aug 28, 2020

You are correct and a fix is included in #9977.

@rix0rrr rix0rrr added the effort/small Small work item – less than a day of effort label Aug 28, 2020
@jogold jogold mentioned this issue Aug 28, 2020
Merged
@mergify mergify bot closed this as completed in #9977 Aug 28, 2020
mergify bot pushed a commit that referenced this issue Aug 28, 2020
@jogold
fix(custom-resources): buffers returned by AwsCustomResource are unus…
7f351ff 
…able (#9977)

Convert buffers to strings when flattening the API response.

Closes #9969, closes #10017


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources bug This issue is a bug. effort/small Small work item – less than a day of effort needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(custom-resources): buffers returned by AwsCustomResource are unusable jogold/aws-cdk
3 participants
@rix0rrr @nathanpeck @jogold