[aws-appsync] Invalid default effect type. (UserPoolConfig.defaultAction)

[civilizeddev]

Problem

CloudFormation suddenly throws:

Invalid default effect type. (Service: AWSAppSync; Status Code: 400; Error Code: BadRequestException)

even though AWS::AppSync::GraphQLApi UserPoolConfig takes DefaultAction as not-required.

So I destroyed the stack to redeploy it because of this issue.

But the redeployment also failed.

I believe the cause must be:

aws-cdk/packages/@aws-cdk/aws-appsync/lib/graphqlapi.ts

Lines 89 to 93 in ad7465d

	* Default auth action
	*
	* @default ALLOW
	*/
	readonly defaultAction?: UserPoolDefaultAction;

aws-cdk/packages/@aws-cdk/aws-appsync/lib/graphqlapi.ts

Lines 528 to 536 in ad7465d

	private setupUserPoolConfig(config?: UserPoolConfig) {
	if (!config) return undefined;
	return {
	userPoolId: config.userPool.userPoolId,
	awsRegion: config.userPool.stack.region,
	appIdClientRegex: config.appIdClientRegex,
	defaultAction: config.defaultAction,
	};
	}

This should be like:

 private setupUserPoolConfig(config?: UserPoolConfig) { 
   if (!config) return undefined; 
   return { 
     userPoolId: config.userPool.userPoolId, 
     awsRegion: config.userPool.stack.region, 
     appIdClientRegex: config.appIdClientRegex, 
     defaultAction: config.defaultAction || UserPoolDefaultAction.ALLOW,
   }; 
 } 

Reproduction Steps

new appsync.GraphQLApi(this, 'api', {
  authorizationConfig: {
    defaultAuthorization: {
      authorizationType: appsync.AuthorizationType.USER_POOL,
      userPoolConfig: {
        // missing defaultAction
        userPool: this.deps.userPool,
      },
    },
  },
})

What did you expect to happen?

No difference.

What actually happened?

Invalid default effect type. (Service: AWSAppSync; Status Code: 400; Error Code: BadRequestException)

Environment

• CLI Version : 1.61.0
• Framework Version: 1.61.0
• Node.js Version: 14.8.0
• OS : macOS
• Language (Version): TypeScript 4.0.2

Other

• AWS::AppSync::GraphQLApi UserPoolConfig

---

This is 🐛 Bug Report