Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): burst and rate limits are set to unlimited when configured to 0 #10088

Merged
merged 6 commits into from
Sep 2, 2020

Conversation

cyuste
Copy link
Contributor

@cyuste cyuste commented Sep 1, 2020

Closes #10071


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@SomayaB SomayaB changed the title Fix rates 0 fix(api-gateway): Fix rates 0 Sep 1, 2020
@nija-at nija-at changed the title fix(api-gateway): Fix rates 0 fix(apigateway): burst and rate limits are set to unlimited when configured to 0 Sep 2, 2020
@cyuste cyuste marked this pull request as ready for review September 2, 2020 10:21
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a931395
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 96f1772 into aws:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[apigateway] Throttling per method not set when value=0
3 participants