Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): kubectl layer customization #10090

Merged
merged 26 commits into from
Sep 2, 2020

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Sep 1, 2020

Allow providing a custom kubectl lambda layer and/or creating the KubectlLayer object with custom configuration (version, aped).

Resolves #7992


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Elad Ben-Israel and others added 10 commits August 18, 2020 19:24
Allow adding Kubernetes resources such as manifests and Helm charts to imported clusters (`eks.Cluster.fromAttributes`).

To enable this behavior, when the cluster is imported, users will have to specify additional information:

 - `kubectlRole` - an IAM role that can issue kubectl commands against the cluster
 - `kubectlEnvironment` (optional) - environment variables for `kubectl`.
 - `kubectlPrivateSubnets` and `kubectlSecurityGroup` - required if the cluster's k8s endpoint is private

Resolves #5383
Allow providing a custom kubectl lambda layer and/or creating the KubectlLayer object with custom configuration (version, aped).

Resolves #7992
@eladb eladb marked this pull request as draft September 1, 2020 09:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 1, 2020
@eladb eladb requested a review from iliapolo September 1, 2020 09:57
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@eladb eladb requested a review from iliapolo September 2, 2020 05:43
Base automatically changed from benisrae/eks-add-manifest-to-imported-cluster to master September 2, 2020 12:06
@eladb eladb marked this pull request as ready for review September 2, 2020 12:51
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 35d000f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0aa7ada into master Sep 2, 2020
@mergify mergify bot deleted the benisrae/eks-customize-kubectl-layer branch September 2, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks] Allow user to configure source for KubectlLayer
3 participants