Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-eks] Allow user to configure source for KubectlLayer #7992

Closed
2 tasks
kaylanm opened this issue May 15, 2020 · 2 comments · Fixed by #10090
Closed
2 tasks

[aws-eks] Allow user to configure source for KubectlLayer #7992

kaylanm opened this issue May 15, 2020 · 2 comments · Fixed by #10090
Assignees
@eladb
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Milestone
[DevPreview] @aws...

Comments

@kaylanm
Copy link
Contributor

kaylanm commented May 15, 2020

Currently the source of KubectlLayer is not configurable and it is not present in some AWS partitions.

Use Case

To use programmatic kubectl support in AWS partitions where aws-lambda-layer-kubectl must be deployed manually, the source must be configurable.

Proposed Solution

Export KubectlLayer and allow it to take a prop that overrides the source.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@kaylanm kaylanm added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 15, 2020
@SomayaB SomayaB added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label May 18, 2020
@eladb eladb added the effort/small Small work item – less than a day of effort label May 20, 2020
@eladb
Copy link
Contributor

eladb commented May 20, 2020

@pahud is this something you'd like to pick up?

@pahud
Copy link
Contributor

pahud commented May 21, 2020

@eladb Absolutely!

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label May 27, 2020
@eladb eladb added the p2 label Jun 24, 2020
@iliapolo iliapolo changed the title EKS: Allow user to configure source for KubectlLayer [aws-eks] Allow user to configure source for KubectlLayer Aug 16, 2020
@kaylanm kaylanm mentioned this issue Aug 21, 2020
Closed
2 tasks
@iliapolo iliapolo added this to the EKS Dev Preview milestone Aug 23, 2020
@eladb eladb assigned eladb and unassigned iliapolo Sep 1, 2020
@iliapolo iliapolo added the in-progress This issue is being actively worked on. label Sep 1, 2020
eladb pushed a commit that referenced this issue Sep 1, 2020
feat(eks): kubectl layer customization
480e049 
Allow providing a custom kubectl lambda layer and/or creating the KubectlLayer object with custom configuration (version, aped).

Resolves #7992
@eladb eladb mentioned this issue Sep 1, 2020
Merged
@mergify mergify bot closed this as completed in #10090 Sep 2, 2020
mergify bot pushed a commit that referenced this issue Sep 2, 2020
feat(eks): kubectl layer customization (#10090)
0aa7ada 
Allow providing a custom kubectl lambda layer and/or creating the KubectlLayer object with custom configuration (version, aped).

Resolves #7992

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
[DevPreview] @aws-cdk/aws-eks
Development

Successfully merging a pull request may close this issue.

feat(eks): kubectl layer customization aws/aws-cdk
5 participants
@pahud @eladb @kaylanm @iliapolo @SomayaB