feat(pipelines): SimpleSynthAction takes array of build commands
#10152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the single-string versions of `buildCommand` and `installCommand`, and turn them into arrays. People don't have to do `'command1 && command2'` anymore but can now simply supply an array of `['command1', 'command2']` which is more natural. Fixes #9357.
nija-at
approved these changes
Sep 3, 2020
| @@ -449,7 +449,7 @@ class MyPipelineStack extends Stack { | |||
| // Then you can login to codeartifact repository | |||
| // and npm will now pull packages from your repository | |||
| // Note the codeartifact login command requires more params to work. | |||
| buildCommand: 'aws codeartifact login --tool npm && npm run build', | |||
| buildCommands: ['aws codeartifact login --tool npm && npm run build'], | |||
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the single-string versions of
buildCommandandinstallCommand, and turn them into arrays.People don't have to do
'command1 && command2'anymore but can nowsimply supply an array of
['command1', 'command2']which is morenatural.
Fixes #9357.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license