Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticloadbalancingv2): more health check validations to NLB target group (#3703) #10205

Merged
merged 2 commits into from Sep 10, 2020
Merged

Conversation

yerzhan7
Copy link
Contributor

@yerzhan7 yerzhan7 commented Sep 6, 2020

Add the following Health Check validations for Network Target Group:

  • healthyThresholdCount and unhealthyThresholdCount must the same
  • healthyThresholdCount and unhealthyThresholdCount must be between 2 and 10

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…roup (#3703)

Add the following Health Check validations for Network Target Group:
 - healthyThresholdCount and unhealthyThresholdCount must the same
 - healthyThresholdCount and unhealthyThresholdCount must be between 2 and 10

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@njlynch njlynch changed the title feat(elasticloadbalancingv2): add more HC validations to NLB target group (#3703) feat(elasticloadbalancingv2): more health check validations to NLB target group (#3703) Sep 10, 2020
@njlynch njlynch added pr-linter/exempt-readme The PR linter will not require README changes labels Sep 10, 2020
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and extra tests!

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e7f7c50
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants