[codepipeline-actions] Can't use a token for branchName in CodeCommitAction

[alanraison]

If a token (e.g. a CfnParameter value) is used to define the branchName of the CodeCommit Repository in a CodeCommitAction, synthesis fails with:

Cannot use tokens in construct ID: <PipelineId>-${Token[TOKEN.192]}-EventRule

Reproduction Steps

import { Stack, Construct, StackProps, CfnParameter } from '@aws-cdk/core';
import { Pipeline, Artifact } from '@aws-cdk/aws-codepipeline';
import { CodeCommitSourceAction } from '@aws-cdk/aws-codepipeline-actions';
import { Repository } from '@aws-cdk/aws-codecommit';

export default class FailingPipelineStack extends Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    const branchName = new CfnParameter(this, 'BranchName', {
      type: 'String',
    });

    const repo = new Repository(this, 'Repository', {
      repositoryName: 'the-repository',
    });

    new Pipeline(this, 'FailingPipeline', {
      stages: [{
        stageName: 'source',
        actions: [
          new CodeCommitSourceAction({
            actionName: 'readSource',
            output: new Artifact('artifact'),
            repository: repo,
            branch: branchName.valueAsString,
          }),
        ],
      }],
    });
  }
}

What did you expect to happen?

Stack is synthesised correctly.

What actually happened?

Stack fails to synthesise with error:

Cannot use tokens in construct ID: DeploymentPipeline145A2410-${Token[TOKEN.192]}-EventRule

Environment

• CLI Version : 1.62.0
• Framework Version:
• Node.js Version: 12.18.3
• OS : Linux (Debian Buster in Docker)
• Language (Version): Typescript 3.9.7

Other

I notice that the cause of this is during SourceAction.bound():

if (createEvent) {
    const branchIdDisambiguator = this.branch === 'master' ? '' : `-${this.branch}-`;
    this.props.repository.onCommit(`${stage.pipeline.node.uniqueId}${branchIdDisambiguator}EventRule`, {
        target: new targets.CodePipeline(stage.pipeline),
        branches: [this.branch],
    });
}

this.branch should probably be checked to see if it's a usuable value (i.e. not a token) and if it is unusable as an ID, a random value created.

The workaround is to set trigger: CodeCommitTrigger.NONE and create my own cloudtrail trigger.

---

This is 🐛 Bug Report

[skinny85]

Hey @alanraison ,

thanks for opening the issue. This is very similar to #9575 for S3SourceAction. Need to fix it for CodeCommitSourceAction.

[skinny85]

@alanraison of course, a Pull Request fixing this would be very welcome 🙂 see here for some tips on how to open us a PR here: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md