Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): add git submodule options of codebuild #10283

Merged
merged 2 commits into from Sep 11, 2020

Conversation

zxkane
Copy link
Contributor

@zxkane zxkane commented Sep 10, 2020

closes #10271


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@SomayaB SomayaB changed the title feat: add git submodule options of codebuild feat(codebuild): add git submodule options of codebuild Sep 10, 2020
@skinny85
Copy link
Contributor

Thanks for opening the PR @zxkane !

One question. Are you certain this property is supported for all Git sources (so CodeCommitSource, GitHubSource, BitBucketSource and GitHubEnterpriseSource)?

Thanks,
Adam

@zxkane
Copy link
Contributor Author

zxkane commented Sep 11, 2020 via email

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for the quick and high-quality contribution @zxkane !

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7cc94ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codebuild] git source miss submodules support
3 participants