feat(eks): EKS is now in Developer Preview #10518

iliapolo · 2020-09-24T19:35:27Z

Graduate the module to Developer Preview.

This PR also includes some last minute API changes we feel make it a little more semantically clear.

In addition, the README was restructured to be more coherent. See rendered version.

Happy to break this down to multiple PR's if you find it hard to review.

BREAKING CHANGE: cluster.addChart renamed to cluster.addHelmChart

eks: NodegroupOptions.launchTemplate renamed to NodegroupOptions.launchTemplateSpec
eks: cluster.addAutoScalingGroup renamed to cluster.connectAutoScalingGroupCapacity
eks: cluster.addNodegroup renamed to cluster.addNoedgroupCapacity
eks: cluster.addCapacity renamed to cluster.addAutoScalingGroupCapacity
eks: CapacityOptions renamed to AutoScalingGroupCapacityOptions.

Resolves #10364

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

packages/@aws-cdk/aws-eks/README.md

iliapolo · 2020-09-29T09:32:10Z

packages/@aws-cdk/aws-eks/README.md

-  version: eks.KubernetesVersion.V1_16,
-  endpointAccess: eks.EndpointAccess.PRIVATE // No access outside of your VPC.
-});
+```text


I'm still not a 100% sure of the value of this. Would love some input.

packages/@aws-cdk/aws-eks/README.md

iliapolo · 2020-09-29T09:32:49Z

packages/@aws-cdk/aws-eks/README.md

@@ -430,177 +458,104 @@ const cluster = eks.Cluster.fromClusterAttributes(this, 'MyCluster', {
 > Instructions on how to build `layer.zip` can be found
 > [here](https://github.com/aws-samples/aws-lambda-layer-kubectl/blob/master/cdk/README.md).

-[aws-lambda-layer-kubectl]: https://github.com/aws-samples/aws-lambda-layer-kubectl
+### VPC Support


This is an entirely new section, would love your feedback on it.

iliapolo · 2020-09-29T09:33:14Z

packages/@aws-cdk/aws-eks/README.md

+  to access the Kubernetes endpoint.
+
+## Known Issues and Limitations


There are quite a few issues users should be aware of, even though there are explicitly mentioned in the relevant section, I also think it would be beneficial to have a clear simple section that emphasizes them.

packages/@aws-cdk/aws-eks/README.md

eladb · 2020-09-29T11:12:48Z

packages/@aws-cdk/aws-eks/README.md

+    * [ARM64 Support](#arm64-support)
+    * [Kubectl Support](#kubectl-support)
+    * [VPC Support](#vpc-support)
+    * [Permissions and Access](#permissions-and-access)


This feels like it should be in a separate topic from "provisioning clusters"

Yeah, definitely some of it. Let me think of a better structure.

eladb · 2020-09-29T11:13:08Z

packages/@aws-cdk/aws-eks/README.md

+      * [Fargate Profiles](#2-fargate-profiles)
+      * [Self Managed Auto Scaling Groups](#3-self-managed-auto-scaling-groups)
+    * [ARM64 Support](#arm64-support)
+    * [Kubectl Support](#kubectl-support)


Why is this in "provisioning clusters"

Because it describes the kubectlLayer and kubectlEnvironment properties which are used to configure new clusters.

Feels like this should be under the "applying manifests" given this is where it's relevant

It will be a bit awkward since its relevant for helm charts as well. I think its ok to introduce this here as part of the cluster configuration, we already mentioned that this library supports applying manifests, so its not completely out of context. I'll add a link to this from the applying manifests section as well.

k?

eladb · 2020-09-29T11:13:36Z

packages/@aws-cdk/aws-eks/README.md

+* [API Reference](https://docs.aws.amazon.com/cdk/api/latest/docs/aws-eks-readme.html)
+* [Architectural Overview](#architectural-overview)
+* [Provisioning clusters](#provisioning-clusters)
+    * [Capacity Types](#capacity-types)


Maybe hoist as a top level section

Decided to get rid of this and just go ahead with detailing the various capacity types.

packages/@aws-cdk/aws-eks/README.md

Review did not consider some comments

…-dev-preview

mergify · 2020-09-29T20:03:10Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2020-09-29T21:42:11Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2020-09-29T22:24:20Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 81c319b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-09-29T22:24:39Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

iliapolo added 4 commits September 24, 2020 20:07

rename addChart => addHelmChart

0af939c

rename capacity methods

ffaa5b1

rename launchTemplate to launchTemplateSpec

107214b

Merge branch 'master' into epolon/10364-eks-dev-preview

3110f3e

mergify bot added the contribution/core This is a PR that came from AWS. label Sep 24, 2020

iliapolo commented Sep 24, 2020

View reviewed changes

packages/@aws-cdk/aws-eks/README.md Show resolved Hide resolved

flip maturity to dev preview

f24e819

iliapolo marked this pull request as ready for review September 24, 2020 21:09

iliapolo added the pr/do-not-merge This PR should not be merged at this time. label Sep 24, 2020

SomayaB assigned iliapolo Sep 25, 2020

iliapolo added 15 commits September 27, 2020 13:24

working on new readme

3add737

mid work

6e00ef1

mid work

d661f85

mid work

c7fa886

mid work

d5aa7e4

mid work

9bbc1bc

mid work

c9e929b

mid work

42a4f72

mid work

20d17a6

mid work

2e23a1d

mid work

4396001

mid work

55dbfad

mid work

aae7274

refactor

14fa878

refactor

37bb76a

iliapolo commented Sep 29, 2020

View reviewed changes

packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved

iliapolo commented Sep 29, 2020

View reviewed changes

packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved

iliapolo commented Sep 29, 2020

View reviewed changes

packages/@aws-cdk/aws-eks/README.md Outdated Show resolved Hide resolved

mid work

a9e849c

iliapolo commented Sep 29, 2020

View reviewed changes

packages/@aws-cdk/aws-eks/README.md Show resolved Hide resolved

iliapolo requested a review from a team September 29, 2020 09:38

eladb previously approved these changes Sep 29, 2020

View reviewed changes

eladb reviewed Sep 29, 2020

View reviewed changes

iliapolo added 4 commits September 29, 2020 14:39

review comments

806ad5e

remove comment

b326e54

more fixups

6c5e62d

add code snippet for passing a mastersRole

2c28aee

iliapolo requested a review from eladb September 29, 2020 11:47

iliapolo added 2 commits September 29, 2020 14:52

remove RoadMap section

a800570

Merge branch 'master' of github.com:aws/aws-cdk into epolon/10364-eks…

2b77291

…-dev-preview

eladb approved these changes Sep 29, 2020

View reviewed changes

iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Sep 29, 2020

Merge branch 'master' into epolon/10364-eks-dev-preview

de41d2d

Merge branch 'master' into epolon/10364-eks-dev-preview

81c319b

mergify bot merged commit b2ce3aa into master Sep 29, 2020

mergify bot deleted the epolon/10364-eks-dev-preview branch September 29, 2020 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eks): EKS is now in Developer Preview #10518

feat(eks): EKS is now in Developer Preview #10518

iliapolo commented Sep 24, 2020 •

edited

iliapolo Sep 29, 2020

iliapolo Sep 29, 2020

iliapolo Sep 29, 2020

eladb Sep 29, 2020

iliapolo Sep 29, 2020

eladb Sep 29, 2020

iliapolo Sep 29, 2020

eladb Sep 29, 2020

iliapolo Sep 29, 2020

eladb Sep 29, 2020

iliapolo Sep 29, 2020 •

edited

mergify bot commented Sep 29, 2020

mergify bot commented Sep 29, 2020

aws-cdk-automation commented Sep 29, 2020

mergify bot commented Sep 29, 2020

		to access the Kubernetes endpoint.

		## Known Issues and Limitations

feat(eks): EKS is now in Developer Preview #10518

feat(eks): EKS is now in Developer Preview #10518

Conversation

iliapolo commented Sep 24, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iliapolo Sep 29, 2020 • edited

Choose a reason for hiding this comment

mergify bot commented Sep 29, 2020

mergify bot commented Sep 29, 2020

aws-cdk-automation commented Sep 29, 2020

AWS CodeBuild CI Report

mergify bot commented Sep 29, 2020

iliapolo commented Sep 24, 2020 •

edited

iliapolo Sep 29, 2020 •

edited