Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): States.ALL doesn't appear last in Retry and Catch arrays #10538

Merged
merged 2 commits into from Sep 29, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 25, 2020

Validate that States.ALL is not combined with other errors in Retry
and Catch arrays and sort those arrays so that States.ALL appears
last.

Closes #10530


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… arrays

Validate that `States.ALL` is not combined with other errors in `Retry`
and `Catch` arrays and sort those arrays so that `States.ALL` appears
last.

Closes aws#10530
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 84259ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a8d7282 into aws:master Sep 29, 2020
@jogold jogold deleted the sfn-retry-catch-sort branch September 30, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[step-functions] Syth of addCatch on LambdaInvoke
3 participants