Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events-targets): option to provide an existing role to use with the StepFunctions State Machine target #10551

Merged
merged 2 commits into from
Sep 30, 2020
Merged

feat(events-targets): option to provide an existing role to use with the StepFunctions State Machine target #10551

merged 2 commits into from
Sep 30, 2020

Conversation

ayush987goyal
Copy link
Contributor

Add option to use existing role for SfnStateMachine

closes #8255

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot dismissed shivlaks’s stale review September 29, 2020 10:49

Pull request has been modified.

@mergify mergify bot dismissed shivlaks’s stale review September 30, 2020 10:22

Pull request has been modified.

@shivlaks shivlaks changed the title fix(events-targets): add option to use existing role for SfnStateMachine feat(events-targets): option to provide an existing role to use with the StepFunctions State Machine target Sep 30, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ayush987goyal
Copy link
Contributor Author

@shivlaks Could you please add the label to merge this change without a change in readme?

@shivlaks
Copy link
Contributor

@shivlaks Could you please add the label to merge this change without a change in readme?

will do, i just realized there's also 1 comment I had re: test that somehow didn't get published - can you take a look at it as well @ayush987goyal

@mergify mergify bot dismissed shivlaks’s stale review September 30, 2020 12:06

Pull request has been modified.

@ayush987goyal
Copy link
Contributor Author

@shivlaks Done the test related changes. You can proceed with merging this by adding the required label.

@shivlaks shivlaks added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 30, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 877efdc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b96efd8 into aws:master Sep 30, 2020
@ayush987goyal ayush987goyal deleted the pr/evenst-state-role branch October 1, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees

@shivlaks shivlaks

Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to provide custom role for aws-events-targets
3 participants
@ayush987goyal @shivlaks @aws-cdk-automation