Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics): syn-nodejs-2.0 runtime #10574

Merged
merged 5 commits into from Sep 29, 2020
Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 28, 2020

syn-nodejs-2.0 is the latest runtime.

See https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html

BREAKING CHANGE: the default runtime is now syn-nodejs-2.0


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! didn't realize this was out already

Comment on lines 80 to 86
/**
* `syn-nodejs-2.0` includes the following:
* - Lambda runtime Node.js 10.x
* - Puppeteer-core version 3.3.0
* - Chromium version 81.0.4044.0
*/
public static readonly SYNTHETICS_NODEJS_2_0 = new Runtime('syn-nodejs-2.0');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably also worth an

@see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html#CloudWatch_Synthetics_runtimeversion-2.0`

to help users make the decision on which runtime fits their use case.

should we also update this doc string

Copy link
Contributor Author

@jogold jogold Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also update this doc string

which one?

Also, how about changing the default runtime?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, bad link from me - doc string

I suppose it is experimental so we could still update the default runtime if it's the sensible thing we want to nudge users towards. thoughts @NetaNir ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that since we are still in the experimental phase it make sense to change it

@mergify mergify bot dismissed shivlaks’s stale review September 29, 2020 12:53

Pull request has been modified.

@jogold jogold changed the title chore(synthetics): add syn-nodejs-2.0 runtime feat(synthetics): syn-nodejs-2.0 runtime Sep 29, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 80b1880
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a3c41ae into aws:master Sep 29, 2020
@jogold jogold deleted the syn-nodejs-2.0 branch September 30, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants