feat(cli): --all flag to select all stacks

[IsmaelMartinez]

Adding the --all option to deploy all stacks.

cdk deploy --all

This is an alias of *. The previous command does the same as the following one:

cdk deploy '*'

Closes #3222

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[IsmaelMartinez]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

Can someone re-trigger this? I have changed twice the title but can't see this triggering. PR should be ready now for review. Thanks

[Chriscbr]

I'm wondering if it might be better to have the command error instead if both "--all" and a list of stacks are provided. I feel like this could help catch user errors, considering that this implementation looks slightly different from how some other CLI tools operate (e.g. in Git, if you run git add --all foo then only foo will be added to your staged files, ignoring the flag).

Can someone re-trigger this? I have changed twice the title but can't see this triggering. PR should be ready now for review.

I think the title needs to be update to say "feat" instead of "feature"

[IsmaelMartinez]

I'm wondering if it might be better to have the command error instead if both "--all" and a list of stacks are provided. I feel like this could help catch user errors, considering that this implementation looks slightly different from how some other CLI tools operate (e.g. in Git, if you run git add --all foo then only foo will be added to your staged files, ignoring the flag).

Can someone re-trigger this? I have changed twice the title but can't see this triggering. PR should be ready now for review.

I think the title needs to be update to say "feat" instead of "feature"

Thanks. I will see when I got another bit of time to add the error message. Sounds reasonable.

[rix0rrr]

I'm not a big fan of this. We don't need this flag as cdk deploy \* already exists (as you yourself noted).

Where's the added benefit?

[IsmaelMartinez]

I'm not a big fan of this. We don't need this flag as cdk deploy \* already exists (as you yourself noted).

Where's the added benefit?

Only created the PR because there is an open ticket.

Happy to change the PR content to add the unit test for the cdk deploy '*' (was not existent before) and the documentation (if that is needed), but better also close the ticket #3222 or another person might end up doing the same PR.

[Chriscbr]

Only my 2 cents, but the cdk design guidelines suggests:

It's okay to enable multiple ways to achieve the same thing, in order to make it more natural for users who come from different mental models.

What kinds of downsides come to mind?

[IsmaelMartinez]

Hi @rix0rrr and @Chriscbr,

In my opinion, there are 3 options on this (on order of preference):

1. default to deploying all stacks if no list of stacks is provided.
2. don't add the --all but document it and add unit test to it.
3. add the --all and add an exception if the user also provides the flag.

In my opinion, it is a bit strange that you need to provide an escaped * as an extra argument (or the list of stack names) if you got more than one stack in an app.

Saying that, it will be a change on functionality but it sort of makes more sense than the current behaviour. It is not that you need to provide your stack name if you only got one.

Let me know if you prefer to put this sort fo conversations in the ticket instead of in the PR.

Ta

[rix0rrr]

After having thought on it, I'm willing to accept this.

Please add an input to the CLI that if --all is provided, stack names are not allowed (and add a descriptive error message).

Pull request has been modified.

[IsmaelMartinez]

Hi @rix0rrr and @Chriscbr,

I pushed a few changes. Touched the "destroy" command also as it has the same flow/logic as the deploy and will otherwise work inconsistently.

I checked the synth, list and diff and they don't need the --all as that is their default behaviour (if you don't specify a list of stacks, they just assume all.

Also, do you want me to edit the https://docs.aws.amazon.com/cdk/latest/guide/cli.html github to ensure this is in sync? Not sure if that automatically updates or you have an internal process to do this.

Thanks in advance!

[gitpod-io]

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: ac827a7
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).