feat(appmesh): add listener timeout to Virtual Nodes #10793

sshver · 2020-10-08T16:38:36Z

Adds listener timeout to Virtual Nodes.

BREAKING CHANGE: IVirtualNode no longer has the addBackends() method. A backend can be added to VirtualNode using the addBackend() method which accepts a single IVirtualService

appmesh: IVirtualNode no longer has the addListeners() method. A listener can be added to VirtualNode using the addListener() method which accepts a single VirtualNodeListener
appmesh: VirtualNode no longer has a default listener. It is valid to have a VirtualNode without any listeners
appmesh: the construction property listener of VirtualNode has been renamed to listeners, and its type changed to an array of listeners
appmesh: the struct VirtualNodeListener has been removed. To create Virtual Node listeners, use the static factory methods of the VirtualNodeListener class

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

skinny85

Thanks for the contribution @sshver !

Before I do a full review, I wanted to ask one thing I noticed. In the VirtualNodeListener, there is a portMapping property, that has a protocol property. I can't help but notice that the 4 values for this Protocol enum correspond to the timeout values here.

I assume that you can only set the timeout for a protocol that you've set in portMapping, and doing it for a different protocol is either an error, or is silently ignored? If that's the case, I wonder whether we're missing a bigger opportunity here to model this in a richer way. Just off the top of my head, what if Protocol was a more sophisticated type instead of just a simple enum, and you could do things like:

const node = new VirtualNode(this, 'node', {
  listener: {
    portMapping: {
      port: 8080,
      protocol: Protocol.http({
        idleTimeout: Duration.minutes(1),
        requestTimeout: Duration.minutes(2),
      }),
    },
    // ...

Let me know what you think of this direction!

dfezzie · 2020-10-12T22:32:52Z

Thanks for the contribution @sshver !

Before I do a full review, I wanted to ask one thing I noticed. In the VirtualNodeListener, there is a portMapping property, that has a protocol property. I can't help but notice that the 4 values for this Protocol enum correspond to the timeout values here.

I assume that you can only set the timeout for a protocol that you've set in portMapping, and doing it for a different protocol is either an error, or is silently ignored? If that's the case, I wonder whether we're missing a bigger opportunity here to model this in a richer way. Just off the top of my head, what if Protocol was a more sophisticated type instead of just a simple enum, and you could do things like:
const node = new VirtualNode(this, 'node', {
  listener: {
    portMapping: {
      port: 8080,
      protocol: Protocol.http({
        idleTimeout: Duration.minutes(1),
        requestTimeout: Duration.minutes(2),
      }),
    },
    // ...
Let me know what you think of this direction!

We do use Protocol throughout the API with varying context. For example, you can use Protocol in the health check portion of virtual nodes, where the idle and perRequest may not necessarily map.

How could you distinguish between places where you can use the properties?

skinny85 · 2020-10-12T23:43:59Z

Before I answer that @dfezzie , can you answer my original question?

I assume that you can only set the timeout for a protocol that you've set in portMapping, and doing it for a different protocol is either an error, or is silently ignored?

sshver · 2020-10-13T02:23:37Z

Before I answer that @dfezzie , can you answer my original question?

I assume that you can only set the timeout for a protocol that you've set in portMapping, and doing it for a different protocol is either an error, or is silently ignored?

The timeout should be set up for a protocol, the listener uses. Doing it for a different protocol is an error. This was a miss from my end. I have updated the pull request and fixed this error.

skinny85 · 2020-10-13T19:07:04Z

Thanks @sshver and @dfezzie . Here's my issue.

So in the current modeling, we have a bunch of completely separate properties (portMapping, healthCheck, timeout ) in VirtualNodeListener. Separate properties usually imply they can be set separately - but that is not the case here. When I set protocol in portMapping to HTTP, I suddenly have a constraint that I also have to use http for the timeout key (I also expect there is a similar constraint with healthCheck).

I'm wondering whether we can capture these invariants into a class that makes it obvious at compile-time what those different constraints are. Something like this:

new appmesh.VirtualNode(this, 'Node', {
  listener: appmesh.Listener.httpListener({
    timeout: {
      // only HTTP timeout properties are valid here!
      // ...
    },
    healthCheck: {
      // no need to specify Protocol here - we know it's HTTP!
    },
    // ...
  },
});

And we would have methods like tcpListener(), grpcListener(), etc.

Thoughts on this?

dfezzie · 2020-10-14T06:33:39Z

@skinny85 I was thinking along these lines as well. I think it is a good pattern for our service to adopt in the CDK as we have multiple instances where we are setting different properties based on the protocol. I implemented this to see how it would work for Gateway Routes as I was working on those during this thread and it works well. It is definitely easier to reason about as a user of CDK and makes implementation a bit simpler as well.

It would require us rewriting a few of the implementations as they stand, but I'm thinking it may be worth the effort

…er necessary

Updated coressponding test.

This reverts commit b348e42.

skinny85

Nice work @sshver ! Some notes below, mainly I don't like the change from a single listener to having many of them in VirtualNode, and also the duplication present in the VirtualNodeListener hierarchy must be addressed.

packages/@aws-cdk/aws-appmesh/README.md

skinny85 · 2020-10-28T23:52:03Z

packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/appmesh.ts

-      },
+      listeners: [appmesh.VirtualNodeListener.httpNodeListener({
+        port: containerextension.trafficPort,
+      })],


Is this correct? What if the protocol is different than HTTP?

I have added a function to add the listener to the virtual node based on protocol.

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

skinny85 · 2020-10-28T23:57:27Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+/**
+ * Represents the properties needed to define a Listeners for a VirtualNode
+ */
+export interface VirtualNodeListenerProps {


Can you please move VirtualNodeListener and all its related types (*NodeListenerProps, * Timeout, etc.) to its own file?

Created virtual-node-listener and moved the related item to that file.

skinny85 · 2020-10-28T23:58:59Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+  /**
+   * Returns an HealthCheck for a VirtualNode
+   */
+  public static renderHealthCheck(pm: PortMapping, hc: HealthCheck | undefined): CfnVirtualNode.HealthCheckProperty | undefined {


This absolutely should not be part of the public API of this module.

Remember that in TypeScript you can have free-floating functions. Please move this to its own file in the lib/private subdirectory of the module, which is the convention we use for module-private APIs like this.

skinny85 · 2020-10-29T00:05:04Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+/**
+ * Represents the properties required to define a GRPC Listener for a VirtualNode.
+ */
+export class GrpcNodeListener extends VirtualNodeListener {


Same here - should not be exported.

skinny85 · 2020-10-29T00:05:22Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+/**
+ * Returns the ListenerTimeoutProperty for GRPC protocol
+ */
+  public static renderTimeout(tm: GrpcTimeout): CfnVirtualNode.ListenerTimeoutProperty {


Same here - this is a utility, not a public API of this class.

skinny85 · 2020-10-29T00:05:58Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+/**
+ * Represents the properties required to define a TCP Listener for a VirtualNode.
+ */
+export class TcpNodeListener extends VirtualNodeListener {


Same here - should not be exported.

skinny85 · 2020-10-29T00:06:43Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+/**
+ * Returns the ListenerTimeoutProperty for TCP protocol
+ */
+  public static renderTimeout(tm: TcpTimeout): CfnVirtualNode.ListenerTimeoutProperty | undefined {


Same here - should be a utility, not a public API of this class.

(BTW, there's a ton of duplication in these. You might want to think about DRYing this whole VirtualNodeListener hierarchy up)

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

---- This is a draft PR to resolve #9533 Takes an approach for creating protocol specific Gateway Routes as described in #10793 This is a draft as I am seeking feedback on the implementation and approach for creating per protocol variants of App Mesh Resources. Before merging: - [x] Approach for per protocol variants defined - [x] Update Gateway Listeners to follow the same pattern - [x] Add more integ tests *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Pull request has been modified.

dfezzie · 2020-10-30T21:10:22Z

packages/@aws-cdk/aws-appmesh/lib/index.ts

@@ -6,3 +6,4 @@ export * from './shared-interfaces';
 export * from './virtual-node';
 export * from './virtual-router';
 export * from './virtual-service';
+export * from './virtual-listener';


I think we should rename this to virtual-node-listener. No reason to not be specific

dfezzie · 2020-10-30T21:25:44Z

packages/@aws-cdk/aws-appmesh/lib/virtual-listener.ts

+/**
+ * Returns an HealthCheck for a VirtualNode
+ */
+function renderHealthCheck(pm: PortMapping, hc: HealthCheck | undefined): CfnVirtualNode.HealthCheckProperty | undefined {


This can be made a protected function of VirtualNodeListener and then you can use the protocol and port of the class instead of having to pass in the PortMapping interface.

dfezzie · 2020-10-30T21:30:13Z

packages/@aws-cdk/aws-appmesh/lib/virtual-listener.ts

+/**
+ * Returns the ListenerTimeoutProperty for HTTP protocol
+ */
+function renderTimeout(tm: any, pr: Protocol): CfnVirtualNode.ListenerTimeoutProperty {


Can this be a protected function of VirtualNodeListener? That way you can just reference the class properties and not pass parameters to this function

dfezzie · 2020-10-30T21:32:50Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+    if (listeners.length + this.listeners.length > 1) {
      throw new Error('VirtualNode may have at most one listener');
    }


We discussed this offline, but wanted to put it here.

We are going to accept the array of listeners without validation. This is to future proof against when we lift the server side validation for a single listener. We do not want to require customers to upgrade their CDK to use multiple listeners

dfezzie · 2020-10-30T21:35:31Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

@@ -258,7 +215,7 @@ export class VirtualNode extends VirtualNodeBase {
    this.mesh = props.mesh;

    this.addBackends(...props.backends || []);
-    this.addListeners(...props.listener ? [props.listener] : []);
+    this.addListeners(...props.listener ? [props.listener] : [VirtualNodeListener.httpNodeListener()]);


We should not default to a listener for virtual nodes. It is valid to create a virtual node without a listener. For example, we may have a service that polls SQS to do some work, and therefore would not need a listener

…imeout

gitpod-io · 2020-11-03T01:40:35Z

skinny85

We're getting closer! A few more comments.

skinny85 · 2020-11-03T23:00:37Z

packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/appmesh.ts

@@ -259,17 +259,33 @@ export class AppMeshExtension extends ServiceExtension {
      throw new Error('You must add a CloudMap namespace to the ECS cluster in order to use the AppMesh extension');
    }

+    function addListener(protocol: appmesh.Protocol, port: number) {


Please specify the return type explicitly.

skinny85 · 2020-11-03T23:00:47Z

packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/appmesh.ts

@@ -259,17 +259,33 @@ export class AppMeshExtension extends ServiceExtension {
      throw new Error('You must add a CloudMap namespace to the ECS cluster in order to use the AppMesh extension');
    }

+    function addListener(protocol: appmesh.Protocol, port: number) {
+      if (protocol === appmesh.Protocol.HTTP2) {


Can you use a switch instead?

switch (protocol) { case appmesh.Protocol.HTTP2: return appmesh.VirtualNodeListener.http2NodeListener({ port }); // ... }

This way, the compiler will guarantee that all enum cases are covered.

skinny85 · 2020-11-03T23:03:57Z

packages/@aws-cdk/aws-appmesh/lib/shared-interfaces.ts

+   *
+   * @default - none
+   */
+  readonly idle?: cdk.Duration;


I believe all these types are used only in the virtual-node-listener.ts file. Can you move them there please?

skinny85 · 2020-11-03T23:05:58Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node-listener.ts

+  /**
+   * Returns an HTTP Listener for a VirtualNode
+   */
+  public static httpNodeListener(props: HttpNodeListenerProps = {}): VirtualNodeListener {


Same comment here as in #11277 (comment). Should we call these http / http2 / grpc / etc.?

skinny85 · 2020-11-03T23:08:04Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node-listener.ts

+  /**
+   * Returns an HTTP2 Listener for a VirtualNode
+   */
+  public static http2NodeListener(props: HttpNodeListenerProps = {}): VirtualNodeListener {


Can you move these *Props interfaces above the VirtualNodeListener class please?

Also, we generally call them Props only when they're used for Construct properties. For static methods like these, they should have the suffix 'Options' (so, HttpNodeListenerOptions).

These *NodeListenerProps are being used to initialize the constructor of the *NodeListener classes as the static method returns *NodeListener object and the props are used to initialize the constructor. Wouldn't it be okay to call them *Props here ?

No, because VirtualNodeListener is not a construct. We use *Props only for construct properties.

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

skinny85 · 2020-11-03T23:16:00Z

packages/@aws-cdk/aws-appmesh/test/test.health-check.ts

+          protocol,
+          path: '/',
+        },
+      })],


I gotta say, I don't understand why do we need changes to these tests...?

skinny85 · 2020-11-03T23:17:43Z

packages/@aws-cdk/aws-appmesh/test/test.virtual-node.ts

@@ -71,15 +70,12 @@ export = {
          meshName: 'test-mesh',
        });

-        const node = mesh.addVirtualNode('test-node', {
+        new appmesh.VirtualNode(stack, 'test-node', {


Why this change...?

packages/@aws-cdk/aws-appmesh/test/test.virtual-node.ts

skinny85 · 2020-11-03T23:19:35Z

packages/@aws-cdk/aws-appmesh/test/test.mesh.ts

@@ -275,7 +272,6 @@ export = {
              'Fn::GetAtt': ['meshACDFE68E', 'MeshName'],
            },
            Spec: {
-              // Specifically: no Listeners and Backends


Why remove this...?

- Removed empty listeners as we will not have a default listener. Listeners can be added to a node after the node is created.

Pull request has been modified.

- Renamed Interface from *Props to *Options.

sshver · 2020-11-06T02:18:46Z

packages/@aws-cdk/aws-appmesh/test/test.virtual-node.ts

@@ -113,19 +273,15 @@ export = {

    const node = mesh.addVirtualNode('test-node', {
      dnsHostName: 'test.domain.local',
-      listener: {},


I have removed the empty listener as we will not have a default listener for a node. It would be valid to have a node without listener and then add it later.

Reference

…ualNode to VirtualNode.

skinny85

Looks good! We're almost there, just needs some finishing touches.

Also make sure to update the PR description, so that it contains all of the breaking changes made in this PR (which is a lot): https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md#step-4-commit

skinny85 · 2020-11-07T00:32:12Z

packages/@aws-cdk/aws-appmesh/README.md

  accessLog: appmesh.AccessLog.fromFilePath('/dev/stdout'),
 });

 cdk.Tag.add(node, 'Environment', 'Dev');
 ```

-The listeners property can be left blank and added later with the `node.addListeners()` method. The `healthcheck` property is optional but if specifying a listener, the `portMappings` must contain at least one property.
+The listeners property can be left blank and added later with the `node.addListeners()` method. The `healthcheck` and `timeout` properties are optional but if specifying a listener, the `port` must be added.


Suggested change

The listeners property can be left blank and added later with the `node.addListeners()` method. The `healthcheck` and `timeout` properties are optional but if specifying a listener, the `port` must be added.

The `listeners` property can be left blank and added later with the `node.addListener()` method. The `healthcheck` and `timeout` properties are optional but if specifying a listener, the `port` must be added.

packages/@aws-cdk/aws-appmesh/lib/shared-interfaces.ts

skinny85 · 2020-11-07T00:36:22Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node-listener.ts

+/**
+ * Represents the properties needed to define a Listeners for a VirtualNode
+ */
+interface VirtualNodeListenerOptions {


Let's call this VirtualNodeListenerCommonOptions.

skinny85 · 2020-11-07T00:36:50Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node-listener.ts

+/**
+ * Represent the HTTP Node Listener prorperty
+ */
+export interface HttpNodeListenerOptions extends VirtualNodeListenerOptions {


I believe this should be called HttpVirtualNodeListenerOptions?

skinny85 · 2020-11-07T00:37:33Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node-listener.ts

+/**
+ * Represent the GRPC Node Listener prorperty
+ */
+export interface GrpcNodeListenerOptions extends VirtualNodeListenerOptions {


Same here (GrpcVirtualNodeListenerOptions).

skinny85 · 2020-11-07T00:52:53Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

-  validateHealthChecks(healthCheck);
-
-  return healthCheck;
+  protected readonly listeners = new Array<VirtualNodeListenerConfig>();


Why is this here? This should be in VirtualNode, right?

skinny85 · 2020-11-07T00:53:15Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

@@ -122,69 +113,11 @@ abstract class VirtualNodeBase extends cdk.Resource implements IVirtualNode {
  public abstract readonly virtualNodeArn: string;

  protected readonly backends = new Array<CfnVirtualNode.BackendProperty>();


This field should be moved to VirtualNode, it's not used in this class.

skinny85 · 2020-11-07T00:54:21Z

packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts

+  /**
+   * Add a Virtual Services that this node is expected to send outbound traffic to
+   */
+  public addBackends(...props: IVirtualService[]) {


Let's make addBackends() consistent with addListener() (call it addBackend(), make it take a single IVirtualService).

We will need a breaking change in the PR description for this too.

skinny85 · 2020-11-07T00:56:40Z

packages/@aws-cdk/aws-appmesh/test/test.virtual-node.ts

+    },
+    'when a listener is added with timeout': {


There should be an empty line between tests on the same level:

Suggested change

},

'when a listener is added with timeout': {

},

'when a listener is added with timeout': {

Same comment for all new tests added.

skinny85 · 2020-11-07T00:57:18Z

packages/@aws-cdk/aws-appmesh/test/test.virtual-node.ts

+        expect(stack).to(
+          haveResourceLike('AWS::AppMesh::VirtualNode', {


These should be on the same line, because otherwise the indentation is weird:

Suggested change

expect(stack).to(

haveResourceLike('AWS::AppMesh::VirtualNode', {

expect(stack).to(haveResourceLike('AWS::AppMesh::VirtualNode', {

Same comment for all other added tests in this PR.

…ner and backend service respectively

…imeout

Pull request has been modified.

skinny85

Looks fantastic @sshver !

Pull request has been modified.

mergify · 2020-11-11T17:34:35Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2020-11-11T18:56:19Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: cf15f6e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-11-11T18:56:45Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

sshver added 2 commits October 7, 2020 21:12

feat(aws-appmesh): adds listener timeout to Virtual Nodes

c0073e6

Update README.md to include listener timeout for Virtual Nodes

97e1275

skinny85 self-assigned this Oct 8, 2020

skinny85 reviewed Oct 8, 2020

View reviewed changes

Added check to set timeout only for those protocol the listener uses

03e012f

dfezzie mentioned this pull request Oct 14, 2020

feat(appmesh): add Virtual Gateways and Gateway Routes #10879

Merged

3 tasks

sshver added 7 commits October 26, 2020 14:47

WIP - Adding VirtualNodeListener Class

3d3e09f

Added descriptive comments

0046aa1

minor edits: added/updated comments and added/removed spaces where ev…

d4f136c

…er necessary

Fixed test after cherry-pick

c520b01

Fixed code to make sure the build does not fail.

b348e42

Updated coressponding test.

Fixed code to make sure the build does not fail.

2fe07eb

Revert "Fixed code to make sure the build does not fail."

9d4f03b

This reverts commit b348e42.

skinny85 previously requested changes Oct 29, 2020

View reviewed changes

addressed comments and removed dupilcations

b012bbb

dfezzie reviewed Oct 30, 2020

View reviewed changes

sshver added 3 commits November 2, 2020 13:06

addressed comment

8c8c2ad

Updated appmesh.ts to add listener based on protocol

8373e3c

Removing unused file from directory

f220deb

sshver requested a review from skinny85 November 3, 2020 00:30

Merge remote-tracking branch 'upstream/master' into feature/listenert…

ae6ad41

…imeout

skinny85 previously requested changes Nov 3, 2020

View reviewed changes

- Updated test to remove unnecessary changes.

03b4c1f

- Removed empty listeners as we will not have a default listener. Listeners can be added to a node after the node is created.

- Moved bind implementation to VirtualNodeListener.

6ff4b82

- Renamed Interface from *Props to *Options.

sshver commented Nov 6, 2020

View reviewed changes

sshver requested a review from skinny85 November 6, 2020 18:48

Removed addListeners and moved addListener and addBackends from IVirt…

a167ae8

…ualNode to VirtualNode.

skinny85 previously requested changes Nov 7, 2020

View reviewed changes

sshver added 2 commits November 9, 2020 15:51

Create addListener() and addBackend() method to accept a single liste…

588b56b

…ner and backend service respectively

Merge remote-tracking branch 'upstream/master' into feature/listenert…

0d70cd7

…imeout

Removed unnecessary whitespaces

b67d48e

sshver requested a review from skinny85 November 10, 2020 03:58

Make the fields in VirtualNode private instead of protected

a2138cd

skinny85 previously approved these changes Nov 10, 2020

View reviewed changes

skinny85 changed the title ~~feat(aws-appmesh): adds listener timeout to Virtual Nodes~~ feat(appmesh): add listener timeout to Virtual Nodes Nov 10, 2020

Merge branch 'master' into feature/listenertimeout

caf3e7c

skinny85 added 2 commits November 10, 2020 15:37

Merge branch 'master' into feature/listenertimeout

be69829

Revert unnecessarily removed empty line in virtual-node.ts

d35705f

skinny85 previously approved these changes Nov 10, 2020

View reviewed changes

Merge branch 'master' into feature/listenertimeout

d8b049c

skinny85 approved these changes Nov 11, 2020

View reviewed changes

Merge branch 'master' into feature/listenertimeout

cf15f6e

mergify bot merged commit 62baa7b into aws:master Nov 11, 2020

sshver mentioned this pull request Dec 9, 2020

feat(appmesh): add timeout support to Routes skiyani/aws-cdk#3

Open

	The listeners property can be left blank and added later with the `node.addListeners()` method. The `healthcheck` and `timeout` properties are optional but if specifying a listener, the `port` must be added.
	The `listeners` property can be left blank and added later with the `node.addListener()` method. The `healthcheck` and `timeout` properties are optional but if specifying a listener, the `port` must be added.

		@@ -122,69 +113,11 @@ abstract class VirtualNodeBase extends cdk.Resource implements IVirtualNode {
		public abstract readonly virtualNodeArn: string;

		protected readonly backends = new Array<CfnVirtualNode.BackendProperty>();

		expect(stack).to(
		haveResourceLike('AWS::AppMesh::VirtualNode', {

	expect(stack).to(
	haveResourceLike('AWS::AppMesh::VirtualNode', {
	expect(stack).to(haveResourceLike('AWS::AppMesh::VirtualNode', {

feat(appmesh): add listener timeout to Virtual Nodes #10793

feat(appmesh): add listener timeout to Virtual Nodes #10793

Conversation

sshver commented Oct 8, 2020 • edited by skinny85

skinny85 left a comment • edited

Choose a reason for hiding this comment

dfezzie commented Oct 12, 2020

skinny85 commented Oct 12, 2020

sshver commented Oct 13, 2020

skinny85 commented Oct 13, 2020 • edited

dfezzie commented Oct 14, 2020

skinny85 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitpod-io bot commented Nov 3, 2020 • edited

skinny85 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skinny85 left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skinny85 left a comment

Choose a reason for hiding this comment

mergify bot commented Nov 11, 2020

aws-cdk-automation commented Nov 11, 2020

AWS CodeBuild CI Report

mergify bot commented Nov 11, 2020

sshver commented Oct 8, 2020 •

edited by skinny85

skinny85 left a comment •

edited

skinny85 commented Oct 13, 2020 •

edited

gitpod-io bot commented Nov 3, 2020 •

edited

skinny85 left a comment •

edited