Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ecs-service-extensions] look up or import an environment #10931

Closed
1 of 2 tasks
misterjoshua opened this issue Oct 18, 2020 · 1 comment · Fixed by #10932
Closed
1 of 2 tasks

[ecs-service-extensions] look up or import an environment #10931

misterjoshua opened this issue Oct 18, 2020 · 1 comment · Fixed by #10932
Assignees
@MrArnoldPalmer
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@misterjoshua
Copy link
Contributor

misterjoshua commented Oct 18, 2020 •
edited

I'd like to use ServiceDescription to create services for an imported ECS cluster.

Use Case

I need to hook into a cluster from another stack and create services to run on that cluster. We do this because we're sharing EC2 capacity between projects to reduce costs. I would like to create services using the ServiceDescription paradigm. However, there is currently no support for ICluster.

Proposed Solution

I suggest that we introduce an IEnvironment interface and implement an Environment.fromEnvironmentAttributes() method.

Other

I've created a PR with a more detailed solution.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@misterjoshua misterjoshua added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2020
@misterjoshua misterjoshua mentioned this issue Oct 18, 2020
Merged
@misterjoshua misterjoshua changed the title [aws-ecs-builder] look up or import an environment [ecs-container-extensions] look up or import an environment Oct 18, 2020
@misterjoshua misterjoshua changed the title [ecs-container-extensions] look up or import an environment [ecs-service-extensions] look up or import an environment Oct 18, 2020
@SomayaB SomayaB added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Oct 19, 2020
@mergify mergify bot closed this as completed in #10932 Nov 2, 2020
mergify bot pushed a commit that referenced this issue Nov 2, 2020
@misterjoshua
feat(ecs-service-extensions): create an Environment from attributes (…
d395b5e 
…#10932)

This PR introduces `Environment.fromEnvironmentAttributes()` so that a user can import a pre-existing cluster.

Closes #10931 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 2, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs-service-extensions): create an Environment from attributes misterjoshua/aws-cdk
3 participants
@misterjoshua @MrArnoldPalmer @SomayaB