feat(aws-codebuild): add COMMIT_MESSAGE support for webhook FilterGroup #11011
Conversation
COMMIT_MESSAGE filter with a PR Event
|
|
There was a problem hiding this comment.
Thanks for a very high-quality contribution @jorge-barreto !
Some minor comments before I merge this in.
| @@ -668,6 +702,17 @@ class GitHubEnterpriseSource extends ThirdPartyGitSource { | |||
| buildTriggers: superConfig.buildTriggers, | |||
| }; | |||
| } | |||
|
|
|||
| private hasCommitMessageFilterAndPREvent() { | |||
There was a problem hiding this comment.
| private hasCommitMessageFilterAndPREvent() { | |
| private hasCommitMessageFilterAndPrEvent() { |
There was a problem hiding this comment.
by the way, I had noticed that one cannot use FILE_PATH filters with GitHub Enterprise Server pull request events either. it may be out of scope for this ticket, but do we want to create a similar hasFilePathFilterAndPrEvent method to check for that?
There was a problem hiding this comment.
Yes, that would be awesome, thanks!
- fix logic on andCommitMessageIsNot - typo hasCommitMessageFilterAndPrEvent - change addFilter first arg's type to WebhookFilterTypes - add PULL_REQUEST_CREATED EventAction to GitHub/BitBucket test
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
closes #9033
A small amount of housekeeping was done by collecting the different string constants for webhook filter types into a single enum
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license