[EC2] ConfigSets not being generated correctly in c#

[hansterwal]

Reproduction Steps

using cdk synth with the following code snippet

var synccmd = InitCommand.ShellCommand("start /wait powershell.exe -ExecutionPolicy RemoteSigned -Command \"& { set-TimeZone 'W. Europe Standard Time' }\"",
                new InitCommandOptions() { 
                 WaitAfterCompletion = InitCommandWaitDuration.Of(Duration.Seconds(0))
                ,Key = "1-sync-time"
                 });            
            var file = Amazon.CDK.AWS.EC2.InitFile.FromString($"c:\\cfn\\cfn-hup.conf","blablalba");
            var configs = new Dictionary<string,InitConfig>();
            
            configs.Add("configurecfn", new InitConfig(new InitFile[]{file}));           
            configs.Add("synctime", new InitConfig(new InitCommand[]{ synccmd }));
            
            var sets = new Dictionary<string,string[]>();
            sets.Add("EC2Win1", new []{ "timezone", "synctime" });
            var configProps = new ConfigSetProps(){
                ConfigSets = sets,
                Configs = configs
            };
              var configsets = Amazon.CDK.AWS.EC2.CloudFormationInit.FromConfigSets(configProps);
            template.AddMetadata("AWS::CloudFormation::Init", configsets);

What did you expect to happen?

      aws:cdk:path: DemoStack-dev/LaunchTemplatehigh
        _configSets:
          EC2Win1:
            - timezone
            - synctime
        _configs:
            configurecfn:
              - files: c:\cfn\cfn-hup.conf
                content:
                     blablalba                
             synctime:
               1-sync-time:
                   - command: start /wait powershell.exe -ExecutionPolicy RemoteSigned -Command "& { set-TimeZone 'W. Europe Standard Time' }"            
                waitAfterCompletion: 0

What actually happened?

it generates the following:Metadata:

      aws:cdk:path: DemoStack-dev/LaunchTemplatehigh
        _configSets:
          EC2Win1:
            - timezone
            - synctime
        _configs:
          configurecfn:
            elements:
              - fileName: c:\cfn\cfn-hup.conf
                options: {}
                elementType: FILE
          synctime:
            elements:
              - command: start /wait powershell.exe -ExecutionPolicy RemoteSigned -Command "& { set-TimeZone 'W. Europe Standard Time' }"
                options:
                  key: 1-sync-time
                  waitAfterCompletion: {}
                elementType: COMMAND

Environment

• CLI Version :2.0.55
• Framework Version :1.69.0
• Node.js Version: v12.18.3
• OS : Windows 10 Pro:
• Language (Version): donet 3.1.101

Other

I don't understand the element and elementType key being emitted AWS Docs don't mention them.

---

This is 🐛 Bug Report

[rix0rrr]

            template.AddMetadata("AWS::CloudFormation::Init", configsets);

Is not how you're supposed to attach this. You're not writing CloudFormation templates.

Read this for EC2 instances: https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ec2-readme.html#configuring-instances-using-cloudformation-init-cfn-init

For ASGs we still need to merge this PR: #9674

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.