Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-cloudwatch] GraphWidget support for different view types #9675 #11063

Closed
cukierkowychleb opened this issue Oct 23, 2020 · 1 comment · Fixed by #11160
Closed

[aws-cloudwatch] GraphWidget support for different view types #9675 #11063

cukierkowychleb opened this issue Oct 23, 2020 · 1 comment · Fixed by #11160
Assignees
@rix0rrr
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2

Comments

@cukierkowychleb
Copy link

cukierkowychleb commented Oct 23, 2020 •
edited
Loading

❓ GraphWidget support for different view types

The Question

Same issue as described in: #9675 (comment) but for GraphWidget.

Currently the GraphWidget supports only "timeseries" view.
It should allow to specify the rest view type:

  • pie
  • bar

Widget type is hardcoded:

aws-cdk/packages/@aws-cdk/aws-cloudwatch/lib/graph.ts

Line 217 in 09e994a

view: 'timeSeries',

Environment

  • CDK CLI Version: 1.67.0
  • Node.js Version: v14.13.1
  • OS: all
  • Language: Java

Other information
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Oct 23, 2020
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2 labels Oct 26, 2020
@AnderEnder AnderEnder mentioned this issue Oct 27, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 28, 2020
@aolundin aolundin mentioned this issue Oct 28, 2020
Closed
2 tasks
@mergify mergify bot closed this as completed in #11160 Nov 10, 2020
mergify bot pushed a commit that referenced this issue Nov 10, 2020
@AnderEnder
feat(cloudwatch): different view types in GraphWidget (#11160)
24de577 
Allow to customise different view types in GraphWidget. The default behavior is backward compatible.

Closes #11063

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): different view types in GraphWidget AnderEnder/aws-cdk
3 participants
@rix0rrr @SomayaB @cukierkowychleb