(cli): progress bar goes over 100% #11805
Labels
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
package/tools
Related to AWS CDK Tools or CLI
Comments
moltar
added
bug
|
This also might be related to Custom Resource that runs on deployment. E.g. log managing lambdas. |
|
I'm seeing this too: [██████████████████████████████████████████████████████████] (158/101) Interestingly, my denominator is also 101. Is there a bug that prevents the total number going above 101? Or is that just a coincidence? |
4 tasks
|
This is because the change count is derived from |
RomainMuller
added
effort/small
mergify bot
pushed a commit
that referenced
this issue
Apr 25, 2022
The deployment monitor failed to account for the fact the `DescribeChangeSet` operation returns a paginated output, and only represents up to 100 changes per pages. Since only the first page was considered, the progress bar would always start with a value of 101 (or less), instead of the correct count. This aggregates the `Changes` arrays from all pages of the change set description so the count is correct. Fixes #11805 ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this issue
Apr 27, 2022
The deployment monitor failed to account for the fact the `DescribeChangeSet` operation returns a paginated output, and only represents up to 100 changes per pages. Since only the first page was considered, the progress bar would always start with a value of 101 (or less), instead of the correct count. This aggregates the `Changes` arrays from all pages of the change set description so the count is correct. Fixes aws#11805 ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Shows: 121/101
Reproduction Steps
Not sure how, maybe it is because of Nested Stacks?
What did you expect to happen?
The completed count should be <= total number.
What actually happened?
The completed count is higher than total count.
Environment
Other
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: