Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): encryption key for environment variables #11893

Merged
merged 2 commits into from Dec 14, 2020

Conversation

alvyn279
Copy link
Contributor

@alvyn279 alvyn279 commented Dec 6, 2020

Notes

Could we please decorate this PR with the pr-linter/exempt-readme label? I don't think this is a big enough feature to add README content.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 6, 2020

@SomayaB SomayaB changed the title feat(aws-lamdba): support kmsKeyArn in lambda Function props feat(lamdba): support kmsKeyArn in lambda Function props Dec 7, 2020
@SomayaB SomayaB changed the title feat(lamdba): support kmsKeyArn in lambda Function props feat(lambda): support kmsKeyArn in lambda Function props Dec 7, 2020
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Dec 7, 2020
nija-at
nija-at previously requested changes Dec 8, 2020
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR. I have one comment below.

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved
@nija-at nija-at changed the title feat(lambda): support kmsKeyArn in lambda Function props feat(lambda): encryption key for environment variables Dec 8, 2020
@mergify mergify bot dismissed nija-at’s stale review December 8, 2020 21:39

Pull request has been modified.

@alvyn279 alvyn279 requested a review from nija-at December 8, 2020 22:27
nija-at
nija-at previously requested changes Dec 9, 2020
packages/@aws-cdk/aws-lambda/package.json Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved
- KMS key used to encrypt lambda env vars can now be specified in L2 Function construct
- fixes aws#10837
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the CDK! 😊

@alvyn279
Copy link
Contributor Author

@nija-at Do I need to fix anything (i.e.: the readme linter issue) for the Mergify bot to merge to master ?

@nija-at nija-at added the pr-linter/exempt-readme The PR linter will not require README changes label Dec 14, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 874c597
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ccbaf83 into aws:master Dec 14, 2020
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
- ARN for KMS key used to encrypt lambda env vars can now be specified in L2 `Function` construct
- fixes aws#10837

#### Notes
Could we please decorate this PR with the `pr-linter/exempt-readme` label? I don't think this is a big enough feature to add README content.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lambda] using encryption configuration kmsKeyArn as parameter not implemented yet.
3 participants