Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudfront): cross-region EdgeFunction does not work within a Stage #12103

Merged
merged 2 commits into from Jan 5, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Dec 16, 2020

The creation of the cross-region stack was always defaulting to the root,
resulting in potential cross-stage dependencies.

fixes #12092


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@njlynch njlynch requested a review from a team December 16, 2020 11:38
@njlynch njlynch self-assigned this Dec 16, 2020
@gitpod-io
Copy link

gitpod-io bot commented Dec 16, 2020

@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Dec 16, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 16, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d90c5f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

The creation of the cross-region stack was always defaulting to the root,
resulting in potential cross-stage dependencies.

fixes #12092
@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 98d781c into master Jan 5, 2021
@mergify mergify bot deleted the njlynch/edge-func-stage branch January 5, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cloudfront): cross region EdgeFunction does not work within a Stage
3 participants