Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pipelines): can't use CodePipeline variables in Synth environment variables #12602

Merged
merged 5 commits into from Jan 25, 2021
Merged

fix(pipelines): can't use CodePipeline variables in Synth environment variables #12602

merged 5 commits into from Jan 25, 2021

Conversation

pgarbe
Copy link
Contributor

@pgarbe pgarbe commented Jan 19, 2021 •
edited by skinny85

Fixes #12061
Fixes #11178

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 19, 2021 •
edited

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Jan 19, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@pgarbe pgarbe changed the title (pipelines): map synth env variables to action fix(pipelines): map synth env variables to action Jan 19, 2021
@skinny85
Copy link
Contributor

@pgarbe thanks for the fix! Would you mind also tackling ShellScriptAction? See #11178 (comment) for details.

@pgarbe
Copy link
Contributor Author

pgarbe commented Jan 20, 2021

@skinny85 added environmentVariables also for ShellScriptAction so that it feels and behaves like the synth actions.

@pgarbe
Copy link
Contributor Author

pgarbe commented Jan 25, 2021

@skinny85 anything I can do to get it merged?

@rix0rrr rix0rrr changed the title fix(pipelines): map synth env variables to action fix(pipelines): can't use CodePipeline variables in Synth environment variables Jan 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 85677da
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 736b260 into aws:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/pipelines CDK Pipelines library
Projects
None yet
Milestone
No milestone
4 participants
@pgarbe @skinny85 @aws-cdk-automation @rix0rrr