fix(cfn2ts): correctly choose between string and object without required properties in a union #12954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rix0rrr
requested changes
Feb 11, 2021
rix0rrr
approved these changes
Feb 11, 2021
…red properties in a union In our code generation, in the validation functions for CFN complex types, we never checked whether the argument we received is an object. Because of that, passing a string was actually a correct candidate for a union with a complex type that had no required properties. Fix that by checking for that error explicitly, which removes the complex type without required properties from the candidates when a string is passed. Fixes aws#12854
skinny85
force-pushed
the
fix/codegen-l1-unions
branch
from
741411f
to
81d9f97
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
…red properties in a union (aws#12954) In our code generation, in the validation functions for CFN complex types, we never checked whether the argument we received is an object. Because of that, passing a string was actually a correct candidate for a union with a complex type that had no required properties. Fix that by checking for that error explicitly, which removes the complex type without required properties from the candidates for the union type when a string is passed. Fixes aws#12854 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our code generation, in the validation functions for CFN complex types,
we never checked whether the argument we received is an object.
Because of that, passing a string was actually a correct candidate for a union with a complex type that had no required properties.
Fix that by checking for that error explicitly,
which removes the complex type without required properties from the candidates for the union type when a string is passed.
Fixes #12854
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license