(backup): Support for advancedBackupSettings

[jhojgaard]

AWS Backup BackupPlan construct is missing support for AdvancedBackupSetting
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-backup-backupplan-advancedbackupsettingresourcetype.html

Use Case

This is needed to support Windows VSS in AWS Backup configured with CDK

Proposed Solution

Add something like: backupOptions: {"WindowsVSS": "enabled"} to support the advanced backup options

Other

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[Patil2099]

@MrArnoldPalmer I would love to work on this issue. Can you guide me a little on how can I solve it?

[MrArnoldPalmer]

hey @Patil2099. This should be pretty straightforward if you checkout the BackupPlan resource you will need to add a new optional property to BackupPlanProps that then is pass in the constructor to the CfnBackupPlan arguments.

[BenChaimberg]

I am unassigning myself and marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to reevaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Please feel free to work on this issue yourself and request my review if you submit a PR or would like design help! See CONTRIBUTING.md for guidelines.

[cyuste]

As a workaround, you can use this code

 const plan = backup.BackupPlan.daily35DayRetention(this, 'Plan');

const cfnPlan = plan.node.defaultChild as backup.CfnBackupPlan;
const currPlan = cfnPlan.backupPlan as backup.CfnBackupPlan.BackupPlanResourceTypeProperty;
const backupPlan : backup.CfnBackupPlan.BackupPlanResourceTypeProperty = {
  ...currPlan,
  advancedBackupSettings: [{
    backupOptions: {"WindowsVSS": "enabled"},
    resourceType : 'EC2',
  }]
};
cfnPlan.backupPlan = backupPlan;

[fitzoh]

I wasn't sure how to do @cyuste 's workaround in python, so here's an alternate method in python:

        plan = aws_backup.BackupPlan.daily35_day_retention(self, "plan")
        cfn_plan: aws_backup.CfnBackupPlan = plan.node.default_child
        cfn_plan.add_property_override(
            "BackupPlan.AdvancedBackupSettings",
            [
                {
                    "BackupOptions": {"WindowsVSS": "enabled"},
                    "ResourceType": "EC2",
                }
            ],
        )

Also looks like #15934 might be getting close to the finish line

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[fitzoh]

Thanks @cokia ! 🎉