Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secretsmanager): Allow cross account grant #14834

Merged
merged 5 commits into from
Jun 25, 2021
Merged

feat(secretsmanager): Allow cross account grant #14834

merged 5 commits into from
Jun 25, 2021

Conversation

workeitel
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 22, 2021

@peterwoodworth peterwoodworth added the @aws-cdk/aws-secretsmanager Related to AWS Secrets Manager label Jun 3, 2021
@workeitel workeitel mentioned this pull request Jun 16, 2021
Merged
njlynch
njlynch previously requested changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @workeitel !

Thanks for this contribution, and sorry for the delay in getting back to you on it.

How have you tested this? I approach anything involving multiple accounts and changes to policies with a healthy amount of skepticism, so just want to ensure you've verified this works when deployed as described. :)

packages/@aws-cdk/aws-secretsmanager/test/secret.test.ts Show resolved Hide resolved
@njlynch njlynch added effort/small Small work item – less than a day of effort p1 labels Jun 24, 2021
@mergify mergify bot dismissed njlynch’s stale review June 24, 2021 19:17

Pull request has been modified.

njlynch
njlynch approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e03af58
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ea40cfe into aws:master Jun 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@workeitel workeitel deleted the secretsmanager-cross-account-grant branch June 25, 2021 19:35
@jrruethe jrruethe mentioned this pull request Jul 30, 2021
Closed
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@workeitel @hollanddd
feat(secretsmanager): Allow cross account grant (aws#14834)
2e73c52 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@workeitel @aws-cdk-automation @njlynch @peterwoodworth