fix(apigateway): id in schema model maps to $id #15113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jihndai
force-pushed
the
id-compliance-draft04
branch
from
be525b3
to
b9feb09
Compare
RomainMuller
force-pushed
the
master
branch
from
924c117
to
ebfd5f2
Compare
jihndai
force-pushed
the
id-compliance-draft04
branch
from
47f5bb4
to
1e5169e
Compare
rix0rrr
added
bug
TheRealAmazonKendra
changed the title
github-actions
bot
added
the
@aws-cdk/aws-apigateway
github-actions
bot
added
bug
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
If we specify the `id` field when defining an Api Gateway Model's schema, it gets mapped to a `$id` key, which creates an invalid model because it doesn't comply with the DRAFT-04 specification. The specification requires this field to remain named as `id`. fixes aws#14585 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we specify the
idfield when defining an Api Gateway Model's schema, it gets mapped to a$idkey, which creates an invalid model because it doesn't comply with the DRAFT-04 specification. The specification requires this field to remain named asid.fixes #14585
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license